search

OriginTrail / dkg-docs

4 stars 9 forks source link

Update setup-instructions-dockerless.md #10

Open ngdias opened 2 years ago

ngdias commented 2 years ago

If you have already cloned the ot-node repository:


/root/ot-node/installer/installer.sh

I think you actually have to be in /root/ot-node for the npm part of the script to work. Not sure about the latest versions of the script though.
ngdias commented 2 years ago

Hum, I read the instructions as a whole and made modifications that sounded better to me. It's not a matter or right or wrong, it's just trying to improve clarity and detail. I submitted the changes as a suggestion for improvement, I don't expect them to necessarily be accepted as is; and I'm totally cool with them being rejected.

I think the docs right now need a little bit of a cleanup, there is at least 1 redundant page imo. Also the flow of information could be reviewed, to make sure the transitions between topics/sections are clear to those who are not familiar with the current events, installation steps, etc. I could take a closer look and suggest changes, if the team sees any value in this.

About your second point: ok.

About the 'review to your version' / 'that one' - I'm not sure exactly which version you are referring too?... I'm happy to offer suggestions if you point me to the files. Cheers!

Valcyclovir commented 2 years ago

I agree the doc needs some cleanup, and the team is behind on PRs and now we have your modifications and mine to review, which would create a conflict if one or the other is merged. On second thought, at this point I think it's best to let the team catch up on the PR first before adding extra layers of changes. Cheers !