Closed hugoesthere closed 7 years ago
Seems like the linter errors are valid, but we're not seeing them locally. Not sure if we were seeing these errors on the feature branch CI tests either. lint-output.txt:
lint-output.txt
DEBUG: PATH=./bin:./node_modules/.bin:/Users/hugoho/go/bin:/Users/hugoho/.yarn/bin:/Users/hugoho/.fzf/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/go/bin DEBUG: GOPATH=/Users/hugoho/go DEBUG: GOBIN= DEBUG: linting path ./src DEBUG: linting path ./src/application DEBUG: linting path ./src/application/deployer DEBUG: linting path ./src/aws DEBUG: linting path ./src/cmd DEBUG: linting path ./src/cmd/exo DEBUG: linting path ./src/config DEBUG: linting path ./src/docker/compose DEBUG: linting path ./src/docker/composebuilder DEBUG: linting path ./src/docker/tools DEBUG: linting path ./src/template DEBUG: linting path ./src/terraform DEBUG: linting path ./src/types DEBUG: linting path ./src/util DEBUG: linting path ./test_helpers DEBUG: [deadcode.1]: executing /Users/hugoho/go/bin/deadcode ./src ./src/application ./src/application/deployer ./src/aws ./src/cmd ./src/cmd/exo ./src/config ./src/docker/compose ./src/docker/composebuilder ./src/docker/tools ./src/template ./src/terraform ./src/types ./src/util ./test_helpers DEBUG: [megacheck.2]: executing /Users/hugoho/go/bin/megacheck ./src ./src/application ./src/application/deployer ./src/aws ./src/cmd ./src/cmd/exo ./src/config ./src/docker/compose ./src/docker/composebuilder ./src/docker/tools ./src/template ./src/terraform ./src/types ./src/util ./test_helpers DEBUG: [gocyclo.3]: executing /Users/hugoho/go/bin/gocyclo -over 10 ./src ./src/application ./src/application/deployer ./src/aws ./src/cmd ./src/cmd/exo ./src/config ./src/docker/compose ./src/docker/composebuilder ./src/docker/tools ./src/template ./src/terraform ./src/types ./src/util ./test_helpers DEBUG: [goconst.4]: executing /Users/hugoho/go/bin/goconst -min-occurrences 3 -min-length 3 ./src ./src/application ./src/application/deployer ./src/aws ./src/cmd ./src/cmd/exo ./src/config ./src/docker/compose ./src/docker/composebuilder ./src/docker/tools ./src/template ./src/terraform ./src/types ./src/util ./test_helpers DEBUG: [vet.8]: executing /usr/local/bin/go tool vet src/aws/ecr_client_helpers.go src/aws/index.go src/aws/repository_helper.go src/aws/secrets_helpers.go src/aws/terraform_helpers.go DEBUG: [vet.5]: executing /usr/local/bin/go tool vet src/version.go DEBUG: [vet.6]: executing /usr/local/bin/go tool vet src/application/clean.go src/application/initializer.go src/application/initializer_test.go src/application/runner.go src/application/service_tester.go src/application/suite_test.go src/application/tester.go DEBUG: [vet.7]: executing /usr/local/bin/go tool vet src/application/deployer/deployer_suite_test.go src/application/deployer/helpers.go src/application/deployer/helpers_test.go src/application/deployer/index.go src/application/deployer/push_application_images.go src/application/deployer/push_image.go src/application/deployer/push_image_options.go DEBUG: [deadcode.1]: deadcode hits 0: ^deadcode: (?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*)$ DEBUG: [deadcode.1]: deadcode linter took 32.568081ms DEBUG: [vet.9]: executing /usr/local/bin/go tool vet src/cmd/add.go src/cmd/clean.go src/cmd/configure.go src/cmd/context.go src/cmd/create.go src/cmd/deploy.go src/cmd/root.go src/cmd/run.go src/cmd/shared.go src/cmd/template.go src/cmd/test.go src/cmd/version.go DEBUG: [goconst.4]: goconst hits 0: ^(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*)$ DEBUG: [gocyclo.3]: warning: /Users/hugoho/go/bin/gocyclo returned exit status 1: 41 testHelpers SharedFeatureContext test_helpers/shared_feature_context.go:42:1 39 testHelpers CleanFeatureContext test_helpers/clean_feature_context.go:26:1 16 testHelpers RunFeatureContext test_helpers/run_feature_context.go:19:1 14 testHelpers TemplateFeatureContext test_helpers/template_feature_context.go:17:1 13 testHelpers CopyDir test_helpers/copy_directory.go:65:1 DEBUG: [goconst.4]: goconst linter took 37.895723ms DEBUG: [vet.10]: executing /usr/local/bin/go tool vet src/cmd/exo/main.go DEBUG: [gocyclo.3]: gocyclo hits 5: ^(?P<cyclo>\d+)\s+\S+\s(?P<function>\S+)\s+(?P<path>.*?\.go):(?P<line>\d+):(\d+)$ DEBUG: nolint: parsing test_helpers/shared_feature_context.go for directives DEBUG: [gocyclo.3]: gocyclo linter took 42.170678ms DEBUG: [vet.11]: executing /usr/local/bin/go tool vet src/config/app_config_helpers.go src/config/app_config_helpers_test.go src/config/app_dependency_test.go src/config/app_development_dependency.go src/config/app_production_dependency.go src/config/exocom_development_dependency.go src/config/exocom_production_dependency.go src/config/generic_development_dependency.go src/config/generic_production_dependency.go src/config/nats_development_dependency.go src/config/rds_production_dependency.go src/config/service_config.go src/config/service_config_test.go src/config/suite_test.go DEBUG: nolint: parsing test_helpers/shared_feature_context.go took 6.259355ms DEBUG: nolint: parsing test_helpers/clean_feature_context.go for directives DEBUG: nolint: parsing test_helpers/clean_feature_context.go took 947.12µs DEBUG: nolint: parsing test_helpers/run_feature_context.go for directives DEBUG: nolint: parsing test_helpers/run_feature_context.go took 462.586µs DEBUG: nolint: parsing test_helpers/template_feature_context.go for directives DEBUG: nolint: parsing test_helpers/template_feature_context.go took 419.452µs DEBUG: nolint: parsing test_helpers/copy_directory.go for directives DEBUG: nolint: parsing test_helpers/copy_directory.go took 434.573µs DEBUG: [vet.5]: vet hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vet.5]: vet linter took 121.451329ms DEBUG: [vet.12]: executing /usr/local/bin/go tool vet src/docker/compose/base_options.go src/docker/compose/image_options.go src/docker/compose/images_options.go src/docker/compose/index.go DEBUG: [vet.7]: vet hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vet.7]: vet linter took 143.383886ms DEBUG: [vet.13]: executing /usr/local/bin/go tool vet src/docker/composebuilder/build_mode.go src/docker/composebuilder/development.go src/docker/composebuilder/index.go src/docker/composebuilder/index_test.go src/docker/composebuilder/production.go src/docker/composebuilder/suite_test.go DEBUG: [vet.6]: vet hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vet.6]: vet linter took 166.123599ms DEBUG: [vet.14]: executing /usr/local/bin/go tool vet src/docker/tools/index.go DEBUG: [vet.12]: vet hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vet.12]: vet linter took 101.981684ms DEBUG: [vet.15]: executing /usr/local/bin/go tool vet src/template/application_yml.go src/template/index.go src/template/service_yml.go DEBUG: [vet.11]: vet hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vet.11]: vet linter took 207.29594ms DEBUG: [vet.16]: executing /usr/local/bin/go tool vet src/terraform/bindata.go src/terraform/command_helpers.go src/terraform/command_helpers_test.go src/terraform/commands.go src/terraform/index.go src/terraform/index_suite_test.go src/terraform/index_test.go src/terraform/template_builder.go DEBUG: [vet.13]: vet hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vet.13]: vet linter took 113.227276ms DEBUG: [vet.17]: executing /usr/local/bin/go tool vet src/types/app_config.go src/types/app_config_test.go src/types/app_context.go src/types/app_development_config.go src/types/app_production_config.go src/types/aws_config.go src/types/context.go src/types/deploy_config.go src/types/development_dependency_config.go src/types/development_dependency_config_options.go src/types/docker_compose.go src/types/docker_config.go src/types/docker_configs.go src/types/env_vars.go src/types/message_translation.go src/types/production_dependency_config.go src/types/production_dependency_config_options.go src/types/production_dependency_config_test.go src/types/rds_config.go src/types/secrets.go src/types/service_config.go src/types/service_config_test.go src/types/service_context.go src/types/service_data.go src/types/service_development_config.go src/types/service_messages.go src/types/service_production_config.go src/types/services.go src/types/shutdown_config.go src/types/suite_test.go DEBUG: [vet.14]: vet hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vet.14]: vet linter took 148.371973ms DEBUG: [vet.18]: executing /usr/local/bin/go tool vet src/util/docker_log.go src/util/docker_log_test.go src/util/exec.go src/util/index_suite_test.go src/util/logger.go src/util/map.go src/util/map_test.go src/util/os_helpers.go src/util/slice.go src/util/string.go DEBUG: [vet.9]: vet hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vet.9]: vet linter took 301.87678ms DEBUG: [vet.19]: executing /usr/local/bin/go tool vet test_helpers/add_feature_context.go test_helpers/clean_feature_context.go test_helpers/copy_directory.go test_helpers/index.go test_helpers/run_feature_context.go test_helpers/shared_feature_context.go test_helpers/template_feature_context.go test_helpers/test_feature_context.go test_helpers/tutorial_feature_context.go DEBUG: [vet.15]: vet hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vet.15]: vet linter took 117.325485ms DEBUG: [errcheck.20]: executing /Users/hugoho/go/bin/errcheck -abspath ./src ./src/application ./src/application/deployer ./src/aws ./src/cmd ./src/cmd/exo ./src/config ./src/docker/compose ./src/docker/composebuilder ./src/docker/tools ./src/template ./src/terraform ./src/types ./src/util ./test_helpers DEBUG: [vet.8]: vet hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vet.8]: vet linter took 352.238074ms DEBUG: [golint.21]: executing /Users/hugoho/go/bin/golint -min_confidence 0.800000 ./src ./src/application ./src/application/deployer ./src/aws ./src/cmd ./src/cmd/exo ./src/config ./src/docker/compose ./src/docker/composebuilder ./src/docker/tools ./src/template ./src/terraform ./src/types ./src/util ./test_helpers DEBUG: [vet.18]: vet hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vet.18]: vet linter took 156.133454ms DEBUG: [gas.22]: executing /Users/hugoho/go/bin/gas -fmt=csv ./src ./src/application ./src/application/deployer ./src/aws ./src/cmd ./src/cmd/exo ./src/config ./src/docker/compose ./src/docker/composebuilder ./src/docker/tools ./src/template ./src/terraform ./src/types ./src/util ./test_helpers DEBUG: [vet.17]: vet hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vet.17]: vet linter took 221.687231ms DEBUG: [aligncheck.23]: executing /Users/hugoho/go/bin/aligncheck ./src ./src/application ./src/application/deployer ./src/aws ./src/cmd ./src/cmd/exo ./src/config ./src/docker/compose ./src/docker/composebuilder ./src/docker/tools ./src/template ./src/terraform ./src/types ./src/util ./test_helpers DEBUG: [vet.16]: vet hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vet.16]: vet linter took 243.263842ms DEBUG: [ineffassign.24]: executing /Users/hugoho/go/bin/ineffassign -n ./src ./src/application ./src/application/deployer ./src/aws ./src/cmd ./src/cmd/exo ./src/config ./src/docker/compose ./src/docker/composebuilder ./src/docker/tools ./src/template ./src/terraform ./src/types ./src/util ./test_helpers DEBUG: [ineffassign.24]: ineffassign hits 0: ^(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*)$ DEBUG: [ineffassign.24]: ineffassign linter took 244.678068ms DEBUG: [interfacer.25]: executing /Users/hugoho/go/bin/interfacer ./src ./src/application ./src/application/deployer ./src/aws ./src/cmd ./src/cmd/exo ./src/config ./src/docker/compose ./src/docker/composebuilder ./src/docker/tools ./src/template ./src/terraform ./src/types ./src/util ./test_helpers DEBUG: [vet.19]: vet hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vet.19]: vet linter took 960.493064ms DEBUG: [structcheck.26]: executing /Users/hugoho/go/bin/structcheck ./src ./src/application ./src/application/deployer ./src/aws ./src/cmd ./src/cmd/exo ./src/config ./src/docker/compose ./src/docker/composebuilder ./src/docker/tools ./src/template ./src/terraform ./src/types ./src/util ./test_helpers DEBUG: [gas.22]: gas hits 0: ^(?P<path>.*?\.go),(?P<line>\d+),(?P<message>[^,]+,[^,]+,[^,]+) DEBUG: [gas.22]: gas linter took 925.51349ms DEBUG: [vetshadow.27]: executing /usr/local/bin/go tool vet --shadow src/version.go DEBUG: [vet.10]: vet hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vet.10]: vet linter took 1.572755017s DEBUG: [vetshadow.28]: executing /usr/local/bin/go tool vet --shadow src/application/clean.go src/application/initializer.go src/application/initializer_test.go src/application/runner.go src/application/service_tester.go src/application/suite_test.go src/application/tester.go DEBUG: [vetshadow.28]: vetshadow hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vetshadow.28]: vetshadow linter took 361.544277ms DEBUG: [vetshadow.29]: executing /usr/local/bin/go tool vet --shadow src/application/deployer/deployer_suite_test.go src/application/deployer/helpers.go src/application/deployer/helpers_test.go src/application/deployer/index.go src/application/deployer/push_application_images.go src/application/deployer/push_image.go src/application/deployer/push_image_options.go DEBUG: [vetshadow.29]: vetshadow hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vetshadow.29]: vetshadow linter took 291.070141ms DEBUG: [vetshadow.30]: executing /usr/local/bin/go tool vet --shadow src/aws/ecr_client_helpers.go src/aws/index.go src/aws/repository_helper.go src/aws/secrets_helpers.go src/aws/terraform_helpers.go DEBUG: [vetshadow.27]: vetshadow hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vetshadow.27]: vetshadow linter took 1.521690668s DEBUG: [vetshadow.31]: executing /usr/local/bin/go tool vet --shadow src/cmd/add.go src/cmd/clean.go src/cmd/configure.go src/cmd/context.go src/cmd/create.go src/cmd/deploy.go src/cmd/root.go src/cmd/run.go src/cmd/shared.go src/cmd/template.go src/cmd/test.go src/cmd/version.go DEBUG: [vetshadow.30]: vetshadow hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vetshadow.30]: vetshadow linter took 769.461318ms DEBUG: [vetshadow.32]: executing /usr/local/bin/go tool vet --shadow src/cmd/exo/main.go DEBUG: [vetshadow.32]: vetshadow hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vetshadow.32]: vetshadow linter took 98.215673ms DEBUG: [vetshadow.33]: executing /usr/local/bin/go tool vet --shadow src/config/app_config_helpers.go src/config/app_config_helpers_test.go src/config/app_dependency_test.go src/config/app_development_dependency.go src/config/app_production_dependency.go src/config/exocom_development_dependency.go src/config/exocom_production_dependency.go src/config/generic_development_dependency.go src/config/generic_production_dependency.go src/config/nats_development_dependency.go src/config/rds_production_dependency.go src/config/service_config.go src/config/service_config_test.go src/config/suite_test.go DEBUG: [vetshadow.33]: vetshadow hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vetshadow.33]: vetshadow linter took 234.115193ms DEBUG: [vetshadow.34]: executing /usr/local/bin/go tool vet --shadow src/docker/compose/base_options.go src/docker/compose/image_options.go src/docker/compose/images_options.go src/docker/compose/index.go DEBUG: [vetshadow.31]: vetshadow hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vetshadow.31]: vetshadow linter took 475.875132ms DEBUG: [vetshadow.35]: executing /usr/local/bin/go tool vet --shadow src/docker/composebuilder/build_mode.go src/docker/composebuilder/development.go src/docker/composebuilder/index.go src/docker/composebuilder/index_test.go src/docker/composebuilder/production.go src/docker/composebuilder/suite_test.go DEBUG: [vetshadow.34]: vetshadow hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vetshadow.34]: vetshadow linter took 102.206341ms DEBUG: [vetshadow.36]: executing /usr/local/bin/go tool vet --shadow src/docker/tools/index.go DEBUG: [vetshadow.36]: vetshadow hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vetshadow.36]: vetshadow linter took 137.96567ms DEBUG: [vetshadow.37]: executing /usr/local/bin/go tool vet --shadow src/template/application_yml.go src/template/index.go src/template/service_yml.go DEBUG: [vetshadow.37]: vetshadow hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vetshadow.37]: vetshadow linter took 129.760348ms DEBUG: [vetshadow.38]: executing /usr/local/bin/go tool vet --shadow src/terraform/bindata.go src/terraform/command_helpers.go src/terraform/command_helpers_test.go src/terraform/commands.go src/terraform/index.go src/terraform/index_suite_test.go src/terraform/index_test.go src/terraform/template_builder.go DEBUG: [vetshadow.38]: vetshadow hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vetshadow.38]: vetshadow linter took 139.325639ms DEBUG: [vetshadow.39]: executing /usr/local/bin/go tool vet --shadow src/types/app_config.go src/types/app_config_test.go src/types/app_context.go src/types/app_development_config.go src/types/app_production_config.go src/types/aws_config.go src/types/context.go src/types/deploy_config.go src/types/development_dependency_config.go src/types/development_dependency_config_options.go src/types/docker_compose.go src/types/docker_config.go src/types/docker_configs.go src/types/env_vars.go src/types/message_translation.go src/types/production_dependency_config.go src/types/production_dependency_config_options.go src/types/production_dependency_config_test.go src/types/rds_config.go src/types/secrets.go src/types/service_config.go src/types/service_config_test.go src/types/service_context.go src/types/service_data.go src/types/service_development_config.go src/types/service_messages.go src/types/service_production_config.go src/types/services.go src/types/shutdown_config.go src/types/suite_test.go DEBUG: [vetshadow.39]: vetshadow hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vetshadow.39]: vetshadow linter took 127.298929ms DEBUG: [vetshadow.40]: executing /usr/local/bin/go tool vet --shadow src/util/docker_log.go src/util/docker_log_test.go src/util/exec.go src/util/index_suite_test.go src/util/logger.go src/util/map.go src/util/map_test.go src/util/os_helpers.go src/util/slice.go src/util/string.go DEBUG: [vetshadow.40]: vetshadow hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vetshadow.40]: vetshadow linter took 116.500423ms DEBUG: [vetshadow.41]: executing /usr/local/bin/go tool vet --shadow test_helpers/add_feature_context.go test_helpers/clean_feature_context.go test_helpers/copy_directory.go test_helpers/index.go test_helpers/run_feature_context.go test_helpers/shared_feature_context.go test_helpers/template_feature_context.go test_helpers/test_feature_context.go test_helpers/tutorial_feature_context.go DEBUG: [golint.21]: golint hits 9: ^(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*)$ DEBUG: [golint.21]: golint linter took 3.874078323s DEBUG: [varcheck.42]: executing /Users/hugoho/go/bin/varcheck ./src ./src/application ./src/application/deployer ./src/aws ./src/cmd ./src/cmd/exo ./src/config ./src/docker/compose ./src/docker/composebuilder ./src/docker/tools ./src/template ./src/terraform ./src/types ./src/util ./test_helpers DEBUG: [vetshadow.41]: vetshadow hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vetshadow.41]: vetshadow linter took 273.708504ms DEBUG: [unconvert.43]: executing /Users/hugoho/go/bin/unconvert ./src ./src/application ./src/application/deployer ./src/aws ./src/cmd ./src/cmd/exo ./src/config ./src/docker/compose ./src/docker/composebuilder ./src/docker/tools ./src/template ./src/terraform ./src/types ./src/util ./test_helpers DEBUG: [vetshadow.35]: vetshadow hits 0: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$ DEBUG: [vetshadow.35]: vetshadow linter took 1.474510944s DEBUG: [aligncheck.23]: aligncheck hits 0: ^(?:[^:]+: )?(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.+)$ DEBUG: [aligncheck.23]: aligncheck linter took 5.150265678s DEBUG: [structcheck.26]: structcheck hits 0: ^(?:[^:]+: )?(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.+)$ DEBUG: [structcheck.26]: structcheck linter took 5.760062402s DEBUG: [errcheck.20]: errcheck hits 0: ^(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*)$ DEBUG: [errcheck.20]: errcheck linter took 7.197294682s DEBUG: [interfacer.25]: interfacer hits 0: ^(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*)$ DEBUG: [interfacer.25]: interfacer linter took 7.091225233s DEBUG: [varcheck.42]: varcheck hits 0: ^(?:[^:]+: )?(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*)$ DEBUG: [varcheck.42]: varcheck linter took 3.967119093s DEBUG: [unconvert.43]: unconvert hits 0: ^(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*)$ DEBUG: [unconvert.43]: unconvert linter took 3.873284576s DEBUG: [megacheck.2]: megacheck hits 0: ^(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*)$ DEBUG: [megacheck.2]: megacheck linter took 9.449078803s DEBUG: total elapsed time 9.463282358s
Try running bin/setup as that will hopefully update your local linter. If that doesn't might need to deleting your locally installed linters.
bin/setup
Seems like the linter errors are valid, but we're not seeing them locally. Not sure if we were seeing these errors on the feature branch CI tests either.
lint-output.txt
: