Originate / exosphere

A modern cloud-based micro-service framework
MIT License
17 stars 6 forks source link

remove environment block #837

Closed charlierudolph closed 6 years ago

charlierudolph commented 6 years ago
# Before
environment:
  default:
  local:
  remote:
  secrets:

# After
# default is removed in favor of using yamls way to share code

local:
  environment:

remote:
  environment:
  secrets:

@alexdavid @hugobho please review. Extracted from https://github.com/Originate/exosphere/issues/429#issuecomment-332694981

hugoesthere commented 6 years ago

This should be

local:
  environment:
  secrets:

remote:
  environment:
  secrets:

to accommodate for local secrets now right?

charlierudolph commented 6 years ago

yep

alexdavid commented 6 years ago

This is going to be so much better 👍

charlierudolph commented 6 years ago

Fixed in 2e6cc954c40983a1acaefd678cad2645949308e6