Hook up release step properly

Originate / recouple

Declarative and type-safe API bridging. Write full-stack applications with ease.

MIT License

4 stars 1 forks source link

Hook up release step properly #50

Closed sleexyz closed 6 years ago

sleexyz commented 6 years ago

The publish-release job actually wasn't being triggered when approved on CircleCI. CircleCi requires you to create a separate "approval job" for triggers, and then declare the triggered job a dependant of the "approval job".

sleexyz commented 6 years ago

When I merged #44 to master, I went ahead and triggered the approval step, but nothing happened:

https://circleci.com/workflow-run/6fa38f99-0a36-4374-8063-b5e67203b1c2

2017-12-04-15 40 42

This PR should fix this.