Open hallettj opened 5 years ago
@hallettj: Do you want to rebase this branch against current master? Or should I take over this PR?
Either way works for me. I will rebase next week if you don't get to it before then.
On Fri, Jun 7, 2019, 15:46 Sönke Hahn notifications@github.com wrote:
@hallettj https://github.com/hallettj: Do you want to rebase this branch against current master? Or should I take over this PR?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Originate/scriptkeeper/pull/194?email_source=notifications&email_token=AAACLFU77ARXBX64M7GGTI3PZK3LDA5CNFSM4HEMFII2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXG2FAY#issuecomment-500015747, or mute the thread https://github.com/notifications/unsubscribe-auth/AAACLFSWWZB4PYIJ7I3SHZ3PZK3LDANCNFSM4HEMFIIQ .
This change is branched from
sh/expected-output
(pr #192) because I wanted to use theexpect_bytes
method that I added in that branch.