Compile under Node v12.

Orion98MC / node_rrd

A node.js native binding for RRDtool (node rrd)

97 stars 25 forks source link

Compile under Node v12. #22

Open jekor opened 4 years ago

jekor commented 4 years ago

I haven't tested this (beyond compilation) or added conditionals for old Node versions without the v8 Isolate argument.

Orion98MC commented 4 years ago

Hi, do you have any insight on how merging this would impact old users?

jekor commented 4 years ago

I would guess the code needs conditionals to support old v8 versions or it won't compile.

Orion98MC commented 4 years ago

Care to add those? :) This is essentially for others. I imagine they would appreciate. I really don't have time to actively maintain this lib anymore as you may have guessed.