Ported to NAN, compiles on v0.11.13

Orion98MC / node_rrd

A node.js native binding for RRDtool (node rrd)

97 stars 25 forks source link

Ported to NAN, compiles on v0.11.13 #8

Closed siboulet closed 9 years ago

siboulet commented 9 years ago

I have ported the module to Nan, effectively allowing build on node v0.11. I have confirmed the module still works on v0.10.29 and all tests are passing.

I haven't heavily test this, so please review and report any problems or feedbacks.

Orion98MC commented 9 years ago

Hi, I'm not used to NAN, I've googled it and correct me if I'm wrong it helps preserve compatibility between node/v8 changes and the native modules throughout versions?

siboulet commented 9 years ago

@Orion98MC yes, more info on NAN here https://github.com/rvagg/nan

It's very popular for native Node modules development: https://www.npmjs.org/browse/depended/nan

timmckenzie commented 9 years ago

With the release of node 0.12.0 can we accept this pull? Future proof this project.

Orion98MC commented 9 years ago

Sorry, had no time to get into it. But it seams okay to me. Cheers