search

OrionFive / Hospitality

Orion's "Hospitality" and more
https://www.patreon.com/orionmods
GNU General Public License v3.0
91 stars 54 forks source link

Hospitality: Offending Empire Royals #738

Closed ryan-garmeson closed 1 year ago

ryan-garmeson commented 1 year ago

Describe the bug Tried to entertain a visiting noble. Noble was offended every time, despite 15+ social on entertainer.

To Reproduce Steps to reproduce the behavior:

  1. Spawn Empire visitors
  2. (hopefully one is high-ranked, I've only seen it with Baron+) Entertain / make friendships

Console log Could not get link, bad request error. Here it is on my github ig: https://github.com/ryan-garmeson/logfiles/blob/cd5d7730e781134cb894dcde5aaddc368f8ab7c7/rimworld20230301

Error stacktrace There is no logged error.

Screenshots If you think it helps, add screenshots to help explain the problem.

Fixing bugs takes a lot of time. Please consider becoming a patron to support development.

ryan-garmeson commented 1 year ago

To be clear this is with Vanilla Empire Expanded.

OrionFive commented 1 year ago

Thanks for the log. I'll see what I can do.

Unfortunately, there's no obvious cause.

tomvd commented 1 year ago

An archduchess came along and I could entertain her after this fix(see PR). She had recruitmentResistanceOffset of 100. I did not try, but I don't think she could ever be recruited. But with a social skill of 15, you should be able -with some luck- to be able to entertain her from time to time.

OrionFive commented 1 year ago

Yeah, not being able to recruit them is by design, because it breaks the whole Royalty gameplay if you can just skip the queue.

I haven't looked at the code for a while, but if I remember correctly, nobles have to be entertained by nobles, or they'll be pretty hard to please.

tomvd commented 1 year ago

Oh, that makes sense. I am rather new in the whole royalty/empire idead. But it does make a lot of sense that people with honor are harder to entertain by "lower class riff-raff" - not matter how well they can speak. So @ryan-garmeson what was the rank of the entertainer, that is the question. Not how much social skill he has :)

OrionFive commented 1 year ago

There is a point, here, though, and that is that this mechanic isn't communicated to the player. So probably ranked guests should have a memory that explains why they were offended, or something else. This isn't obviously to players.

OrionFive commented 1 year ago

@tomvd I've looked into this. Your fix was correct. At some point, RimWorld must have changed the offset from values like 0.1 to values like 100. I've pushed a fix.