search

OrkestraOnline / Orkestra_Online

Orkestra Online is a cloud based platform for deploying, documenting and securing DynamoBIM and Grasshopper content.
https://www.orkestra.online
36 stars 2 forks source link

Pushing graphs from user account #110

Closed Dre-Tas closed 3 years ago

Dre-Tas commented 3 years ago

So I wanted to check if user accounts can push graphs to Orkestra through the Dynamo VE as I thought they couldn't but I wanted to double check.

Well then I've made a pretty scary discovery: it turns out they can! But that messes up the whole platform. I'm not sure if it's because I was previously logged in as an admin and then I logged in with a user account, but somehow, as a user, I managed to open the Dynamo VE and push a graph to Orkestra. The problem is that as a user you cannot select in which folder you want to upload. You can only select the hub.

The first time I tried this I had Orkestra 1.2 installed and it simply started freaking out giving all sorts of errors (both in Revit and in the desktop app) like the following: MicrosoftTeams-image (8) Screenshot 2021-07-28 172719

Then I uninstalled 1.2 and installed 1.1 and then I saw what was happening. So it looks like Orkestra automatically creates a dummy workspace without a name and puts the script there: Screenshot 2021-07-28 172901

And this must mess up Orkestra 1.2 because of the whole renaming mechanism that is now in place. Once you delete that dummy workspace all goes back to normal also in 1.2

In my opinion users shouldn't be allowed to push stuff to Orkestra. That's an admin thing. If you're a user or if you're not logged in they shouldn't be able to push. They might be able to open the Dynamo graph (maybe they're trying to learn how it works) I'm fine with that, but the possibility that the whole platform stops working because something like that happened is dangerous.

Hopefully I was clear enough explaining the issue, but happy to chat about it!

MostafaElAyoubi commented 3 years ago

Hey @Dre-Tas ! You have indeed stumbled upon a 🐞 that's been discovered recently and is already fixed in the upcomming hotfix. Both users AND admins can push definitions directly into hubs and that kind of messes things up. Hub shouln't have any content directly pushed into them.

Dre-Tas commented 3 years ago

Neither the workplace should have any content, right?

Sorry but I'm not sure if I got your answer right: so users are supposed to be able to push graphs online? If yes, that's actually a pretty good thing, but can we limit the folders where they can push?

MostafaElAyoubi commented 3 years ago

No users are not supposed to be able to push anything anywhere 😄. We're working on a third "level" of access though which is the "Editor" level. They'll be able to open definitions and suggest pushes but their operations will have to be reviewed and accepted by admins.

MostafaElAyoubi commented 3 years ago

fixed in 1.2.1