search

OrkestraOnline / Orkestra_Online

Orkestra Online is a cloud based platform for deploying, documenting and securing DynamoBIM and Grasshopper content.
https://www.orkestra.online
36 stars 2 forks source link

Cant Enable "Search Bar" #214

Closed JonathannHaslett closed 8 months ago

JonathannHaslett commented 1 year ago

Describe the bug

  1. Existing OkPy file when i try toggle on the search bar it will appear but when i am in the OkPy IDE but when i execute the file from the browsers or quick access the search bar does not appear.

To Reproduce Steps to reproduce the behavior:

  1. Go to existing OkPy file with sheets, toggle "searchable" to on
  2. Try clicking save, publish, apply when in the node editor.
  3. Try saving the main OkPy files.
  4. See error - Screenshots below.
  5. When OkPy file is run again no search bar appears

Expected behavior Search Bar should show.

Observed behavior Appears to have trouble saving?

Screenshots If applicable, add screenshots to help explain your problem. image

image

Desktop (please complete the following information):

In Which context did it happen (please select from the following list) : Orkestra Desktop app , Orkestra Revit Addin, Orkestra Dynamo View Extension

Additional context Add any other relevant info about the problem here.

JonathannHaslett commented 1 year ago

If i create a brand new OkPy file I can enable search, but when I type along the top to filter the list it doesn't work.

image

MostafaElAyoubi commented 1 year ago

thank you for reporting this @JonathannHaslett ! we're going to look into adding the search bar to existing tools. I believe the search does work though. On your second screenshot, it looks like it navigated low enough for items containing "bs07" to appear. We could make it so the item gets highlighted to. But it is true that the items won't be brought to top of the list. I just browses lox enough for it to show. I hope this makes sens.

JonathannHaslett commented 1 year ago

Thanks Mostafa, i guess i was expecting the search to filter out data so the only thing you see in the list would only be items/ strings that contains BS07, maybe this is not possible?

MostafaElAyoubi commented 1 year ago

oh interesting! yes that could be implemented for sure. Let's keep this topic open until it is.

MostafaElAyoubi commented 1 year ago

@JonathannHaslett Coming along nicely! 😁 ListviewSearch

JonathannHaslett commented 1 year ago

@JonathannHaslett Coming along nicely! 😁 ListviewSearch

Look good Mostafa :)

Any idea when this will become available

MostafaElAyoubi commented 1 year ago

Hey @JonathannHaslett ! Target for next release is october 🤞

MostafaElAyoubi commented 8 months ago

Implemented in 1.8.0