search

Orlandster / vue-typed-js

Typed.js integration for vue.js. Create a typing animation.
http://www.mattboldt.com/demos/typed-js/
MIT License
478 stars 38 forks source link

How to stop events emitting after component is destroyed #5

Closed juanfabrega closed 5 years ago

juanfabrega commented 5 years ago

Hey, love the library!

After implenting it on a project, I noticed that the module is emitting events in a loop even after the component which renders it is destroyed. How can I stop event triggers after I'm no longer on the page that features VueTypedJs?

Thanks!

Orlandster commented 5 years ago

Hey, Thanks for contributing to the project. This seems to be a bug. I will implement a destroy hook during the next week, which kills the typed.js instance.

Sent with GitHawk

juanfabrega commented 5 years ago

Ok sounds good. If I have time I’d be happy to contribute a PR for this. Will give it a shot.

On Sat, Feb 9, 2019 at 10:26 AM Orlando Wenzinger notifications@github.com wrote:

Hey, Thanks for contributing to the project. This seems to be a bug. I will implement a destroy hook during the next week, which kills the typed.js instance.

Sent with GitHawk http://githawk.com

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Orlandster/vue-typed-js/issues/5#issuecomment-462053301, or mute the thread https://github.com/notifications/unsubscribe-auth/ATAkxOYX0aLSeVD3N3RfmaoSZayPPJ0Yks5vLuihgaJpZM4akR36 .