Update to .NET 3.1 and VS 2019 and latest Orleans version 3.1.5.

OrleansContrib / Orleans.Clustering.Kubernetes

Orleans Membership provider for Kubernetes

MIT License

188 stars 47 forks source link

Update to .NET 3.1 and VS 2019 and latest Orleans version 3.1.5. #39

Closed lovettchris closed 4 years ago

lovettchris commented 4 years ago

Update solution to VS 2019 and projects to .NET core 3.1. Update Orleans versions to:

Microsoft.Orleans.Core.Abstractions (3.1.5)
Microsoft.Orleans.CodeGenerator.MSBuild (3.1.5)
Microsoft.Orleans.Core (3.1.5)

Made KubeClient a tiny bit more interesting.

siennathesane commented 4 years ago

@xontab are you able to take a look at this and see if it's viable for merging?

xontab commented 4 years ago

@xontab are you able to take a look at this and see if it's viable for merging?

I believe that libraries should use the min supported version to increase backwards compatibility. Thus I do not think it is a good idea that the dependencies are updated since someone might still be using older versions of Orleans and .NET Core 3.0 in production. So I think that the latest Orleans and .NET version should be referenced in the Host project and controlled by the user (diamond dependency).

galvesribeiro commented 4 years ago

Hey! Thanks for the PR. I've just released the v2 which contains the new client and several improvements. I'm closing this PR as it is outdated as of now but thanks for the contribution!