search

OrleansContrib / Orleans.Providers.MongoDB

A MongoDb implementation of the Orleans Providers: Membership, Storage and Reminders.
MIT License
100 stars 43 forks source link

Investigate compatibility with Orleans v4 preview #100

Closed jeremylcarter closed 1 year ago

jeremylcarter commented 2 years ago

I think we should investigate compatibility with the breaking changes coming in Orleans v4.

I have forked the repository and will see what work is involved.

jeremylcarter commented 2 years ago

I have done the major legwork to target .NET Core 3.1 and Orleans v4.

https://github.com/jeremylcarter/Orleans.Providers.MongoDB/tree/feature/orleans_v4

I was unable to get the unit tests to work , due to lack of understanding how they are wired up with the included lib dll's. The integration test works, and passes however.

SebastianStehle commented 2 years ago

Thanks for your work.

Many important test classes are not available as nuget package, therefore I just built Orleans myself and added everything to the libs folder.

Created an issue for that: https://github.com/dotnet/orleans/issues/7817

jeremylcarter commented 2 years ago

Oh I see! So I just need to get the latest of those classes and compile them?

On Sat, 25 June 2022, 7:57 pm Sebastian Stehle, @.***> wrote:

Thanks for your work.

Many important test classes are not available as nuget package, therefore I just built Orleans myself and added everything to the libs folder.

Created an issue for that: dotnet/orleans#7817 https://github.com/dotnet/orleans/issues/7817

— Reply to this email directly, view it on GitHub https://github.com/OrleansContrib/Orleans.Providers.MongoDB/issues/100#issuecomment-1166245258, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAP5TKMOECO4KH5TGLQBWGLVQ3JZ5ANCNFSM5ZZRV7YA . You are receiving this because you authored the thread.Message ID: @.*** com>

SebastianStehle commented 2 years ago

Yes, exactly. it sucks, but I think it is better than writing these tests manually.

jeremylcarter commented 2 years ago

It wasn't a big deal upgrading, I quite enjoyed it.

On Sat, 25 June 2022, 7:57 pm Sebastian Stehle, @.***> wrote:

Thanks for your work.

Many important test classes are not available as nuget package, therefore I just built Orleans myself and added everything to the libs folder.

Created an issue for that: dotnet/orleans#7817 https://github.com/dotnet/orleans/issues/7817

— Reply to this email directly, view it on GitHub https://github.com/OrleansContrib/Orleans.Providers.MongoDB/issues/100#issuecomment-1166245258, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAP5TKMOECO4KH5TGLQBWGLVQ3JZ5ANCNFSM5ZZRV7YA . You are receiving this because you authored the thread.Message ID: @.*** com>

jeremylcarter commented 2 years ago

@SebastianStehle I will need some help getting the tests organized.

SebastianStehle commented 1 year ago

How is it going?

SebastianStehle commented 1 year ago

In the current branch the tests were actually not running. I fixed that.

jeremylcarter commented 1 year ago

I'll sort out a branch this week and collaborate with you if you're keen. Thanks.

MarkusGeigerDev commented 1 year ago

How are things going, folks? I also had a quick look and made quite a progress after yesterdays release of Orleans 7 but then I stumbled across the same issue with the ./libs. @jeremylcarter: Should we work together to get this up and running for Orleans 7? I would even considering stepping in as a (co-)maintainer for this package.

SebastianStehle commented 1 year ago

How are things going, folks? I also had a quick look and made quite a progress after yesterdays release of Orleans 7 but then I stumbled across the same issue with the ./libs.

We could just use a git submodule and import the necessary project files into the solution.

I would even considering stepping in as a (co-)maintainer for this package.

I am not using Orleans anymore so I would really appreciate that.

MarkusGeigerDev commented 1 year ago

We could just use a git submodule and import the necessary project files into the solution.

Good idea. Could you help to prepare that?

I would even considering stepping in as a (co-)maintainer for this package.

I am not using Orleans anymore so I would really appreciate that.

Yeah, I read about that in the other issue. I'm on the other hand am just getting deeper into it and I am definitely interested in keeping the MongoDB support alive :)

SebastianStehle commented 1 year ago

Good idea. Could you help to prepare that?

I can have a look, but I guess it would be a good first issue for you as well ;) ...

so

  1. Import libs from submodule
  2. Create 3.X branch
  3. Work on 4.X migration
jeremylcarter commented 1 year ago

Did you want to catch up? I'll push up my branch.

On Fri, 11 Nov 2022, 4:17 am Sebastian Stehle, @.***> wrote:

Good idea. Could you help to prepare that?

I can have a look, but I guess it would be a good first issue for you as well ;) ...

so

  1. Import libs from submodule
  2. Create 3.X branch
  3. Work on 4.X migration

— Reply to this email directly, view it on GitHub https://github.com/OrleansContrib/Orleans.Providers.MongoDB/issues/100#issuecomment-1310626118, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAP5TKN6GPGPQTA752EX7BDWHUU4HANCNFSM5ZZRV7YA . You are receiving this because you were mentioned.Message ID: @.*** com>

jeremylcarter commented 1 year ago

My branch is here:

jeremylcarter/Orleans.Providers.MongoDB at feature/orleans_v4 (github.com) https://github.com/jeremylcarter/Orleans.Providers.MongoDB/tree/feature/orleans_v4

Commits:

Comparing OrleansContrib:master...jeremylcarter:feature/orleans_v4 · OrleansContrib/Orleans.Providers.MongoDB (github.com) https://github.com/OrleansContrib/Orleans.Providers.MongoDB/compare/master...jeremylcarter:Orleans.Providers.MongoDB:feature/orleans_v4

On Fri, 11 Nov 2022 at 07:29, Jeremy Carter @.***> wrote:

Did you want to catch up? I'll push up my branch.

On Fri, 11 Nov 2022, 4:17 am Sebastian Stehle, @.***> wrote:

Good idea. Could you help to prepare that?

I can have a look, but I guess it would be a good first issue for you as well ;) ...

so

  1. Import libs from submodule
  2. Create 3.X branch
  3. Work on 4.X migration

— Reply to this email directly, view it on GitHub https://github.com/OrleansContrib/Orleans.Providers.MongoDB/issues/100#issuecomment-1310626118, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAP5TKN6GPGPQTA752EX7BDWHUU4HANCNFSM5ZZRV7YA . You are receiving this because you were mentioned.Message ID: @.*** com>

SebastianStehle commented 1 year ago

Just create a PR and I can help and review

MarkusGeigerDev commented 1 year ago

My branch is here: jeremylcarter/Orleans.Providers.MongoDB at feature/orleans_v4 (github.com)

Thanks! I'm looking through your changes and comparing them to mine. It seems like there were a few breaking changes between v4-rc and v7 and I'm trying to kind of merge what you did with my changes. I suggest that I will push my branch when I'm ready and then let's decide what to bring forward as a PR.

MarkusGeigerDev commented 1 year ago

@jeremylcarter Here's my port: https://github.com/MarkusGeigerDev/Orleans.Providers.MongoDB/tree/Orleans_v7 I still didn't get the unit tests to work - I will probably try Sebastian's suggestion with the submodules later

SebastianStehle commented 1 year ago

I have created a PR to visualize the changes.

MarkusGeigerDev commented 1 year ago

BTW: I followed these guidelines and hints: https://learn.microsoft.com/en-us/dotnet/orleans/whats-new-in-orleans