search

OrleansContrib / Orleans.Providers.MongoDB

A MongoDb implementation of the Orleans Providers: Membership, Storage and Reminders.
MIT License
100 stars 43 forks source link

Reminders after silo restart #117

Closed frfly closed 1 year ago

frfly commented 1 year ago

Hello!

There is an issue, when using MongoDb as storage for reminders. When you create reminder, it has DateTimeKind.Utc . But when you restart silo, reminder entry restores with DateTimeKind.Unspecified . So if you have, e.g., timezone GMT+3, you`ll have to wait for additional three hours until reminder start.

It was fixed here, but then rolled back.

MarkusGeigerDev commented 1 year ago

Hi @frfly, thanks for investigating this! Do you think you can post a pull request? I'll be happy to review it next week. Thanks and happy new year! M.

SebastianStehle commented 1 year ago

Somehow the fix did not comply with the tests. Therefore it was reverted.

wassim-k commented 1 year ago

Yeh, I saw your comment @SebastianStehle on the other thread, I'll try and have a look at this tonight.