search

OrleansContrib / Orleans.Providers.MongoDB

A MongoDb implementation of the Orleans Providers: Membership, Storage and Reminders.
MIT License
100 stars 43 forks source link

Fix reminders not running after silo restart #91

Closed PDarkTemplar closed 2 years ago

PDarkTemplar commented 2 years ago

fix reminders not running after silo restart

SebastianStehle commented 2 years ago

Can we somehow test this?

PDarkTemplar commented 2 years ago

It was fixed in this commit https://github.com/OrleansContrib/Orleans.Providers.MongoDB/commit/3a568ea35a80663632ad89d3c84ce615dc650dbc#diff-7c555a6918e0ebb6fddda2e0bf941698896d0f3afed7c2ba37f894a59dddc962R35

And then for some reason it was reverted here https://github.com/OrleansContrib/Orleans.Providers.MongoDB/pull/72/files#diff-7c555a6918e0ebb6fddda2e0bf941698896d0f3afed7c2ba37f894a59dddc962R35

PDarkTemplar commented 2 years ago

Bump

PDarkTemplar commented 1 year ago

@SebastianStehle This bug came back again: https://github.com/OrleansContrib/Orleans.Providers.MongoDB/blob/master/Orleans.Providers.MongoDB/Reminders/Store/MongoReminderDocument.cs#L35

SebastianStehle commented 1 year ago

I just made all the tests from Orleans itself green. They were not running properly. Perhaps another fix is needed.