search

OrleansContrib / Orleans.Providers.MongoDB

A MongoDb implementation of the Orleans Providers: Membership, Storage and Reminders.
MIT License
105 stars 44 forks source link

Adds the ability to use a different strategy for creating keys #93

Closed diegofrata closed 2 years ago

diegofrata commented 2 years ago

This PR adds a way of customizing what the persisted key looks like. For a particular use case I want to keep just the grain string key as ID, rather than the entire reference, and this option would be handy.

SebastianStehle commented 2 years ago

Great. You can also increase the nuget version number. It should be published then automatically.

diegofrata commented 2 years ago

@SebastianStehle I am struggling to run any of the tests locally. I just noticed there are no tests as part of the automate build. Any ideas before I increase the version?

SebastianStehle commented 2 years ago

It is such a minor change. Looks good for me.

Perhaps we should have validation of this field, so that nobody sets it to null.

diegofrata commented 2 years ago

Good call. Added the validation.

diegofrata commented 2 years ago

@SebastianStehle The publish failed with: 403 (The specified API key is invalid, has expired, or does not have permission to access the specified package.). I think you need to generate a new key in Nuget and update the build secrets

SebastianStehle commented 2 years ago

Yes, thank you. Will do it today