search

OrleansContrib / OrleansTestKit

Unit Test Toolkit for Microsoft Orleans
http://dotnet.github.io/orleans
MIT License
78 stars 43 forks source link

at least let the property checks for logging go thru #116

Closed amccool closed 2 years ago

amccool commented 3 years ago

this is wildly naïve, but the logging in the application that I need tests for is blocked by the Not Implemented exceptions. In the grand scheme: Is anyone actually using the handleIds or namespace from the stream?

seniorquico commented 3 years ago

iirc, we intentionally left these unimplemented in order to solicit feedback on how they're used in the real world. The logging scenario is the first use-case that I've heard. Can you identify what the real providers return and how that differs from the fake implementation proposed? Is it possible these properties could be used in business logic (meaning, could the fake values lead to test failures)? If yes, would it make more sense to allow for customized setup of the values as part of the fixture?