OrloDavid / Anycubic_Kobra_Go_Neo_Marlin_Firmware

Aycubic Kobra Go Firmware Modifications and Fixes w\ support for XSymmetry
GNU General Public License v3.0
0 stars 0 forks source link

Confirm all references to live LCD data is the correct data #1

Open OrloDavid opened 11 months ago

OrloDavid commented 11 months ago

Due to the Multi-modified Marlin mix-n-mash...code-stash, Sorry, code base (couldn't resist), there are variables which basically serve the same function, but from different versions. So, for example, you might have something like "driving force" in one version of Marlin but then it's changed to "driving speed". This may completely match and replace the former, or it might just be the closest thing there is and maybe it operates mostly the same or very different but could return the same metrics. Either way, they both now coexists when normally they wouldn't, or most likely wouldn't base on the dozen versions of Marlin that I have combed through, very Apple like approach on backwards compatibility. I picture someone getting a dart board each year to help determine something random to refactor, just for "funsies". I digress, back to topic. I think some of the LCD code may be off due to this, or maybe it's because some of the code is Anycubic and not Marlin code so it's just not looking at the right place for the data, or it is but it's not asking properly. I haven't had time to dig deeper beyond "I see shit on the screen, and it appears to be within a reasonable assumption..." you get the idea. I wasn't super thrilled after wasting weeks working non-stop on the first firmware to go back and trash it all, then start over from scratch because I couldn't trust some of the "borrowed" code. Maybe that's a bad way to word it, I myself am not a programmer by trade, I've developed my own methods for working through various fields, as proficient as my talent level allows anyway, and sometimes I need a full view and full knowledge over whatever the subject may be, in order to be proficient. In that instance I wasn't sure of the exact code changes, or more so, the why behind everything. I thought I could keep more code intact by making similar changes, even if that meant leaving UBL disabled but getting many other things to work, and I did. I'm not sure if UBL will be beneficial beyond the advanced features I fixed/enabled for ABL, but this Todo needs to be completed first as well as the menu restructuring. This will help to re-unify the code and if UBL mesh storage and recall is still an issue then it will be much easier to troubleshoot. I'm guessing space issue, but could be anything at this point.