search

OrnitheMC / enigma

A deobfuscation/remapping tool for Java bytecode, fork of cuchaz's Enigma.
GNU Lesser General Public License v3.0
9 stars 2 forks source link

Check mappings against the style guide #4

Closed thdaele closed 2 years ago

thdaele commented 2 years ago
viktor40 commented 2 years ago

As per #9 the Static Final fields are checked against the style guide. Which other parts of the style guide do we want to check in enigma?

SpaceWalkerRS commented 2 years ago

Which other parts of the style guide do we want to check in enigma?

Most points in the style guide are naming conventions, which makes checking against them rather difficult, I imagine (not least because some of them depend on the very mappings we use).

viktor40 commented 2 years ago

Personally I think there might be some easy things we can add. For example if we decide on a set of abbreviations to use or not to use. For example if you use minimum instead of min. That would be easy to check. But that would maybe be something we can discuss after the revised style guide is finished.

thdaele commented 2 years ago

Well we can easily check if a class starts with a capital letter. Same for methods and fields those have to start with a regular letter.

viktor40 commented 2 years ago

that should be implemented now

viktor40 commented 2 years ago

This issue got accidentally closed when merging #9 . I hereby reopen this issue for further mapping checks that will come when we finished the new style guide.