OroArmorModding / Netherite-Plus-Mod

Adds new Netherite features to Minecraft
https://oroarmor.com/mods/netherite_plus
MIT License
44 stars 6 forks source link

[Forge/1.16.5] - Disabling items spams the log #59

Closed iArkant closed 3 years ago

iArkant commented 3 years ago

When disabling any item of the mod in the config, the log gets spam with more than 2000 lines of errors of the item that is disabled. The errors are about not finding the recipe/loot_table of the disabled item.

To Reproduce Set false any item in config.

Here is a segment of the spam when the shulker boxes are disabled, this is not a major problem but it causes a lot of residues when looking for other log data.

[00:20:53] [Server thread/ERROR]: Parsing error loading recipe netherite_plus:netherite_gray_shulker_box
com.google.gson.JsonSyntaxException: Unknown item 'netherite_plus:netherite_gray_shulker_box'
    at net.minecraft.item.crafting.ShapedRecipe.lambda$deserializeItem$0(ShapedRecipe.java:262) ~[?:?]
    at java.util.Optional.orElseThrow(Unknown Source) ~[?:1.8.0_281]
    at net.minecraft.item.crafting.ShapedRecipe.func_199798_a(ShapedRecipe.java:261) ~[?:?]
    at net.minecraft.item.crafting.SmithingRecipe$Serializer.func_199425_a_(SmithingRecipe.java:72) ~[?:?]
    at net.minecraft.item.crafting.SmithingRecipe$Serializer.func_199425_a_(SmithingRecipe.java:68) ~[?:?]
    at net.minecraft.item.crafting.RecipeManager.func_215377_a(RecipeManager.java:141) ~[?:?]
    at net.minecraft.item.crafting.RecipeManager.func_212853_a_(RecipeManager.java:61) ~[?:?]
    at net.minecraft.item.crafting.RecipeManager.func_212853_a_(RecipeManager.java:38) ~[?:?]
    at net.minecraft.client.resources.ReloadListener.func_215269_a(SourceFile:13) ~[?:?]
    at java.util.concurrent.CompletableFuture.uniAccept(Unknown Source) ~[?:1.8.0_281]
    at java.util.concurrent.CompletableFuture$UniAccept.tryFire(Unknown Source) ~[?:1.8.0_281]
    at java.util.concurrent.CompletableFuture$Completion.run(Unknown Source) ~[?:1.8.0_281]
    at net.minecraft.resources.AsyncReloader.func_219557_a(SourceFile:71) ~[?:?]
    at net.minecraft.util.concurrent.TickDelayedTask.run(SourceFile:18) ~[?:?]
    at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213166_h(ThreadTaskExecutor.java:172) ~[?:?]
    at net.minecraft.util.concurrent.RecursiveEventLoop.func_213166_h(SourceFile:23) ~[?:?]
    at net.minecraft.server.MinecraftServer.func_213166_h(MinecraftServer.java:733) ~[?:?]
    at net.minecraft.server.MinecraftServer.func_213166_h(MinecraftServer.java:159) ~[?:?]
    at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213168_p(ThreadTaskExecutor.java:134) ~[?:?]
    at net.minecraft.server.MinecraftServer.func_213205_aW(MinecraftServer.java:716) ~[?:?]
    at net.minecraft.server.MinecraftServer.func_213168_p(MinecraftServer.java:710) ~[?:?]
    at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213161_c(ThreadTaskExecutor.java:150) ~[?:?]
    at net.minecraft.server.MinecraftServer.func_240780_a_(MinecraftServer.java:1304) ~[?:?]
    at net.minecraft.command.impl.ReloadCommand.func_241062_a_(SourceFile:22) ~[?:?]
    at net.minecraft.command.impl.ReloadCommand.func_198598_a_(SourceFile:53) ~[?:?]
    at com.mojang.brigadier.CommandDispatcher.execute(CommandDispatcher.java:262) ~[brigadier-1.0.17.jar:?]
    at net.minecraft.command.Commands.func_197059_a(Commands.java:217) ~[?:?]
    at net.minecraft.network.play.ServerPlayNetHandler.func_147361_d(ServerPlayNetHandler.java:1119) ~[?:?]
    at net.minecraft.network.play.ServerPlayNetHandler.func_244548_c(ServerPlayNetHandler.java:1102) ~[?:?]
    at net.minecraft.network.play.ServerPlayNetHandler.func_147354_a(ServerPlayNetHandler.java:1081) ~[?:?]
    at net.minecraft.network.play.client.CChatMessagePacket.func_148833_a(SourceFile:36) ~[?:?]
    at net.minecraft.network.play.client.CChatMessagePacket.func_148833_a(SourceFile:9) ~[?:?]
    at net.minecraft.network.PacketThreadUtil.lambda$checkThreadAndEnqueue$0(PacketThreadUtil.java:34) ~[?:?]
    at net.minecraft.util.concurrent.TickDelayedTask.run(SourceFile:18) ~[?:?]
    at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213166_h(ThreadTaskExecutor.java:172) ~[?:?]
    at net.minecraft.util.concurrent.RecursiveEventLoop.func_213166_h(SourceFile:23) ~[?:?]
    at net.minecraft.server.MinecraftServer.func_213166_h(MinecraftServer.java:733) ~[?:?]
    at net.minecraft.server.MinecraftServer.func_213166_h(MinecraftServer.java:159) ~[?:?]
    at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213168_p(ThreadTaskExecutor.java:134) ~[?:?]
    at net.minecraft.server.MinecraftServer.func_213205_aW(MinecraftServer.java:716) ~[?:?]
    at net.minecraft.server.MinecraftServer.func_213168_p(MinecraftServer.java:710) ~[?:?]
    at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213161_c(ThreadTaskExecutor.java:150) ~[?:?]
    at net.minecraft.server.MinecraftServer.func_213202_o(MinecraftServer.java:696) ~[?:?]
    at net.minecraft.server.MinecraftServer.func_240802_v_(MinecraftServer.java:645) ~[?:?]
    at net.minecraft.server.MinecraftServer.lambda$startServer$0(MinecraftServer.java:232) ~[?:?]
    at java.lang.Thread.run(Unknown Source) [?:1.8.0_281]

Minecraft 1.16.5 netherite-plus-mod-1.3.15-1.16.5-forge forge-36.0.14

OroArmor commented 3 years ago

yes this is a known issue. its not that big of a deal, as i don't have an easy way to fix it yet.