OroArmorModding / Oro-Config

A simple mod config with ModMenu and command integration
MIT License
11 stars 3 forks source link

Implementation of ModMenu #1

Open kmorales13 opened 3 years ago

kmorales13 commented 3 years ago

Hello. I've implemented your library into my mod, and so far it works great. I just have one small issue, and that is that the modMenu integration doesn't seem to work for me.

This is the error I get in the console: Mod provides a broken implementation of ModMenuApi

My config class https://pastebin.com/2hd5gr1d

OroArmor commented 3 years ago

Could i see your modmenu entry point?

kmorales13 commented 3 years ago
"entrypoints": {
    "main": ["net.sleeppunisher.SleepPunisher"],
    "modmenu": ["net.sleeppunisher.ModMenuIntegration"]
  },
package net.sleeppunisher;

import com.oroarmor.config.screen.ModMenuConfigScreen;

public class ModMenuIntegration extends ModMenuConfigScreen {
    public ModMenuIntegration() {
        super(SleepPunisher.CONFIG);
    }
}
OroArmor commented 3 years ago

and what version of modmenu are you using?

kmorales13 commented 3 years ago

2.1.0

OroArmor commented 3 years ago

Modmenu, not oro config, sorry. Also apologies for the late response, I turned some of my github notifications down and it made things worse

kmorales13 commented 3 years ago

ah my bad, its 1.16.8. no worries

OroArmor commented 3 years ago

Huh yeah everything should be fine. Do you have a repository I could look at/tinker with?

kmorales13 commented 3 years ago

yup here's my mod, it's missing the entrypoint btw

ChocolateLoverRaj commented 3 years ago

My mod also has a broken implementation.

ChocolateLoverRaj commented 3 years ago

it's missing the entrypoint btw

@kmorales13 can you commit your latest changes and then tell us the branch (if it's on another branch).