Open panda7281 opened 1 year ago
This sounds very good. Since I haven’t paid attention to lightglue-related information for a while, I will upgrade and maintain the version of the code in the repository in the future.❤️
I have modified the project to adapt v1.0.0: Fused LightGlue-ONNX and tested it on Linux platform. Hope to help anyone who want to use LightGlue on Linux. LightGlue-OnnxRunner
Thank you for your contribution. Are you willing to initiate a pull request? After I review that there are no problems, I will merge it into the master branch and add you to the contributors.❤️
I don't have windows env, so I delete many codes which not be used in Linux. Avoiding to make too much change, I need some time to optimize the code before make a pull request. I will do this soon.
I have modified the project to adapt v1.0.0: Fused LightGlue-ONNX and tested it on Linux platform. Hope to help anyone who want to use LightGlue on Linux. LightGlue-OnnxRunner
really help, thanks
Thank you for your contribution. Are you willing to initiate a pull request? After I review that there are no problems, I will merge it into the master branch and add you to the contributors.❤️
Sorry, I'm pretty new to github and don't know how to properly submit a pull request, maybe you can merge this into your code? I'll mark this as closed
By the way, i think you should add virtual destructor to BaseFeatureMatchOnnxRunner
, or the derived class won't be destruct properly
Thank you for your contribution. Are you willing to initiate a pull request? After I review that there are no problems, I will merge it into the master branch and add you to the contributors.❤️
Sorry, I'm pretty new to github and don't know how to properly submit a pull request, maybe you can merge this into your code? I'll mark this as closed By the way, i think you should add virtual destructor to
BaseFeatureMatchOnnxRunner
, or the derived class won't be destruct properly
Thank you for your contribution and for pointing out the bug about the destructor. I will review your code and merge it later, and update the code as soon as possible. I hope this issue can be kept open so that more people who need help can see it. ,Thanks again❤️
https://github.com/fabio-sim/LightGlue-ONNX/releases/tag/v1.0.0 Recently LightGlue-ONNX released there fused model which improve the performance substantially(~2x faster in my test) and change the format of the output tensor, making the current code not functional
output_tensors[2]
is now the shape of (matchnum, 2) and the pairs are already computed(so you don't need to compute them yourself)output_tensors[3]
is now the shape of (matchnum), which denotes the matching score of each matchThe following simple hack should do the work:
Maybe you can add a flag for the new fused model, thanks!