search

Oromis / touch20

Chrome extension that adds touchscreen support to Roll20
1 stars 7 forks source link

Touch20 not working at all #23

Open spindocks opened 2 years ago

spindocks commented 2 years ago

Recent Roll20 update makes touch20 not work at all for me.

lukeduif commented 2 years ago

I can move and zoom the map and select objects and tokens. But cant move objects and tokens anymore after resent roll20 update.

nlekas commented 2 years ago

I am seeing the same issues. Was trying to play a game with it on 9/3/2022 and could not move tokens. Could select tokens and manipulate their stickers. Toolbar seems to be working. Zoom and pan works. Just token dragging seems to be broken.

nlekas commented 2 years ago

I noticed in testing that it seems to still fully function on Kiwi browser on Android.

hans5500 commented 2 years ago

Same issue here. Exaclty like nlekas commented. Kiwi is sadly not an option on my touch pc.

Oromis commented 2 years ago

Ok I see. I don use Roll20 actively any more but I'll try to find out what's wrong and what I need to do to fix it. I'm on vacation right now but I'll try to carve out time for that afterwards.

nlekas commented 2 years ago

I'm trying to help out. Kind of new to JS and extension building, I mostly do data pipelines and predictive algorithms these days. @Oromis if you don't actively use this anymore and don't want to maintain my buddy and I are happy to help. I just built a touch screen digital table top that requires this to work so I have a vested interest.

nlekas commented 2 years ago

@hans5500 As a bandaid for my games till this is fixed I am using Nox android emulator and it runs Kiwi and the plug-in pretty well. The menus are a bit oversized, but the core functionality is there. I tested other emulators (Mumu, Bluestacks, Gameloop) but Nox is the only one I could get to work right.

On a native android device it just seems to work. Tested that on a couple of Lenovo tablets and the S21+.

I know emulators are resource hogs so that this may not work for you, but just wanted to put it out there.

Oromis commented 2 years ago

@nlekas That would be great! Feel free to submit a PR with the fix and once you feel comfortable I can happily give you maintainer permissions for Touch20 :)

hans5500 commented 2 years ago

@Oromis or @nlekas any updates on this issue? Would be amazing if you guys could get it to work again! Thanks in advance!

nlekas commented 2 years ago

Hey @hans5500 ! Thanks for reaching out. Myself and a colleague are working on this. We are also updating the dependencies to reduce vulnerability and increase compatibility with modern systems.

I've got a good handle on the code base now and believe I've got my head around Roll20. Tried a few ideas that haven't worked so far. I believe updating the dependencies may be part of the solution.

I'm putting as much time towards this as I can. I am also new to JS so there is a learning curve there. Don't mind doing it though as I want to learn JS and have a vested interest in this extension working. I built a digital table top for in-person games that relies on this. Literally played for 1 month before this broke... (sad dnd noises).

Azurenn commented 2 years ago

I just had to make an account and reach out to thank you folks in advance for taking up the work for this. As a new Dm setting up a game for a few friends new to the hobby, having access to Touch 20 with my laptop would be a dream. I just want to let y’all know your effort is appreciated. Same goes to Oromis who started this all. Thanks in advance guys!

nlekas commented 2 years ago

@Azurenn No problem. Happy to help. If you're interested, I've got the details of my digital table top setup if you are interested. I still evolving it, but this is what I have so far,

mvanormer commented 2 years ago

Also hitting this issue, very happy to see someone attempting to address it. Would love for it to be fixed!

nlekas commented 2 years ago

Hey @mvanormer!

@anelson87 and I are still working on it. I had to re-learn JS because I hadn't done it since high school 22 years ago. Wow, has the language evolved! Really hitting my stride with it now though. Also, I don't really know the inner workings of Roll20 very well, but I am learning. Their environment is pretty interesting.

Hoping to figure it out soon now that I've got a clean build. Getting closer to the issue everyday. My schedule right now only allows limited time to work on it, but rest assured we are working on it. I aim to fix it, Just not sure when.

Along the way I've had to do things like update the package dependencies and the webpack to get this to build. Starting out I couldn't even get it to load in my dev & testing environments because of the issues. I thought maybe some outdated and deprecated deps might have had something to do with this issue. Sadly, that was not the case. But now it builds super cleanly and is updated to current tools. I am also noting done quality of life improvements I want to make for later.

Had a bit of a break through yesterday. For some reason the touchmove and touchend events are not registering. I think I am on to something there. Touchstart registers and that is why you can select the tokens, but without the move and end it seems the token dragging/dialog moving and other move based functions aren't working.

nlekas commented 1 year ago

Got to where the tokens register touch again. Still can't move them, but they are no longer a dead spot on the screen.

Previously, basic browser touch allowed a token to be selected. However, this did not fire any of the Touch20 event listeners. Got it to where now the touch fires the listener.

Move is not working as expected for anything using the simpleTouchHandler. There is more to Unpack there.

hans5500 commented 1 year ago

@nlekas First of all, I really appreciate that you are trying to fix this issue. Are you making any progress? Do think you'll be able to solve it or do you think we'll need help from someone else?

dredanath commented 1 year ago

@Oromis and @nlekas thanks for working this. Do you guys have a gofundme? I would be happy to send you over a few bucks if it would motivate and accelerate the fix process. I suspect others would as well. Over COVID I built a touch screen digital table top, so I too have a vested interest.

nlekas commented 1 year ago

We do not, but maybe we will set on up. That is really generous and we deeply appreciate it. We've had to take Dec off our personal development projects due to my work commitments, a much needed family vacation, and a tragedy.

We are going to jump back in January after I get back from vacation. Sorry this is taking so much time. We have limited hours and life is taking up a lot of time these days. Plus, this is a lot of new territory for us tech wise so we are having to learn a lot along the way.

The hope is to get it working and continue to enhance and maintain in the long term until Roll20 officially offers touch support.

dredanath commented 1 year ago

I understand. December is a hectic month. Enjoy your vacation and recharge.Thanks for all your hard work.  My condolences on your loss (tragedy).Thanks,FredSent from my Verizon, Samsung Galaxy smartphone -------- Original message --------From: Noah Lekas @.> Date: 12/26/22 2:29 PM (GMT-05:00) To: Oromis/touch20 @.> Cc: dredanath @.>, Comment @.> Subject: Re: [Oromis/touch20] Touch20 not working at all (Issue #23) We do not, but maybe we will set on up. That is really generous and we deeply appreciate it. We've had to take Dec off our personal development projects due to my work commitments, a much needed family vacation, and a tragedy. We are going to jump back in January after I get back from vacation. Sorry this is taking so much time. We have limited hours and life is taking up a lot of time these days. Plus, this is a lot of new territory for us tech wise so we are having to learn a lot along the way. The hope is to get it working and continue to enhance and maintain in the long term until Roll20 officially offers touch support.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

hans5500 commented 1 year ago

The problem seams to be already fixed. I've played my last two sessions with the touchscreen again, without a problem

dredanath commented 1 year ago

So it is. I just tried and worked fine. I’m glad, I still wonder why it stopped and now started working again? Oh well, don’t look a gift horse in the mouth. Thanks!!

From: hans5500 @.> Sent: Tuesday, December 27, 2022 3:19 AM To: Oromis/touch20 @.> Cc: dredanath @.>; Comment @.> Subject: Re: [Oromis/touch20] Touch20 not working at all (Issue #23)

The problem seams to be already fixed. I've played my last two sessions with the touchscreen again, without a problem

— Reply to this email directly, view it on GitHub https://github.com/Oromis/touch20/issues/23#issuecomment-1365703435 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A46TYXKNQOBFYBMEWEPHMMTWPKQ6PANCNFSM6AAAAAAQB2P6YM . You are receiving this because you commented. https://github.com/notifications/beacon/A46TYXLYJWHBWHYLYRF32XDWPKQ6PA5CNFSM6AAAAAAQB2P6YOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSRM35QW.gif Message ID: @. @.> >

-- This email has been checked for viruses by Avast antivirus software. www.avast.com