search

Orrielel / BetterDiscordAddons

Just a few plugins for BetterDiscord
11 stars 2 forks source link

Only show media controls on hover #11

Closed Liz-chan closed 5 years ago

Liz-chan commented 5 years ago

Seems pretty self-explanatory; hiding the media controls when you're not hovering over the video like YouTube behaves.

Orrielel commented 5 years ago

Good one, been slowly doing the media player after a recent Discord update (they went from Chromium 56 to 69), which completely fucked up the native player controls. So now I'm just copying the Discord player, but with small alterations.

The hovering should be on by default tbh.

Liz-chan commented 5 years ago

So now that it only shows on hover, you can't really tell it's a video to play unless you hover over it. Maybe put a play button overlay when the video isn't playing to indicate it's a video. Only before the video starts playing though, since some people might want to pause the video to take a screenshot sometimes.

Also maybe remove the shadow from the top that shows up whenever you hover over the video.

Orrielel commented 5 years ago

Yeah good idea!

The shadow is something from the default Discord style, but haven't really annoyed me. I've had a previous comment on it causing play/pause issues when clicking the video, which I'm aware off, but been slightly lazy about looking into. Is it that what you're referring to, or just the shadow itself?

Liz-chan commented 5 years ago

Oh, I hadn't even noticed that it blocks you from clicking the video, that's annoying. Well that's another reason to remove it. But the main reason that I asked was because aesthetically I think it would look better without a shadow. I think it's there to distinguish the buttons from the video, but maybe you could give all the buttons an outline or a shadow, so you can always see them.

Orrielel commented 5 years ago

Damn you're fast. Yeah, an outline should be feasible. I'll cook something up throughout the day.

Add me on Orrie#1000 if you want a quicker response. 👍

Liz-chan commented 5 years ago

Yeah, I get instant notifications from my email haha. Happy to hear it, best of luck!