search

Orthodox-Union / zmanim-docs

21 stars 3 forks source link

Returned Data Keys are Inconsistent #1

Closed MosheBerman closed 6 years ago

MosheBerman commented 7 years ago

The keys in the response JSON switch between camel case and snake case. For example:

"specialShabbos":false, "parsha_shabbos":"Tzav",

Some of the methods have this problem too.

binyamin commented 6 years ago

@MosheBerman FYI, I called OU's media department, and I the fact that there is an outstanding issue is being forwarded to the appropriate person.

blocka commented 6 years ago

@b3u this API grew out of the needs of the OU's website and was developed organically over a long period of time. It is used in many places, and changing the keys would be a major breaking change. I'm closing this issue since this is not a bug.

binyamin commented 6 years ago

@blocka Thanks. I had thought some of the endpoints were down, but they're working now.