search

Ortuna / padrino-pipeline

Sprockets for padrino apps
MIT License
21 stars 8 forks source link

Broken tests #33

Open mauriciopasquier opened 9 years ago

mauriciopasquier commented 9 years ago

I got these failures when runing tests from master:

Run options: --seed 59812

# Running:

.......F....................S...........................................F..........................

1) Failure: sprockets_javascript::css#test_0002_finds the example bootstrap gem with a require directive [test/pipelines/sprockets/test_bootstrap.rb:41]:
Expected /normalize\.css/ to match "<!DOCTYPE html>\n<html>\n<head>\n.................

2) Failure: Padrino::Pipeline::Sprockets::asset_compression#test_0001_should not compress css in development mode [test/test_compression.rb:48]:
Expected /body\ \{\n/ to match "body{display:none}\n".

Number 2 didn't happen with every seed:

Run options: --seed 44568

# Running:

....S.........................................................F....................................

I was about to submit a pr for #20 but I don't want to break anything :P

Ortuna commented 9 years ago

I'll take a look at whats going on here. Seems like failure 1 is an html rendered error of some sort? and the second one is being compressed when it shouldn't be compressed.