search

Orvid / Champollion

A PEX to Papyrus Decompiler for Skyrim, Fallout 4 and Starfield
GNU Lesser General Public License v3.0
106 stars 20 forks source link

C++20 support, add static lib target, Skyrim support #5

Closed nikitalita closed 1 year ago

nikitalita commented 1 year ago

This adds support for building on C++20 and adds a static library target to make this easily vcpkg-able and consumed downstream.

the thing that gave me the most trouble was the r/l-value changes in C++20; the tricks used to pipe stuff into ostream/ostringstream broke pretty badly. I attempted to fix it by using double references, but it often doesn’t work, so there’s a lot of "AsString()" scattered around the code now when writing. I’m not sure how to fix this properly, so if you have any ideas, let me know.

this also addresses the issues with the previous PR.

nikitalita commented 1 year ago

I just noticed that I missed dumptree removals from the last PR, reminder to myself to fix before merging