search

Orvid / Champollion

A PEX to Papyrus Decompiler for Skyrim, Fallout 4 and Starfield
GNU Lesser General Public License v3.0
106 stars 20 forks source link

Fix Event tagging #7

Closed nikitalita closed 1 year ago

nikitalita commented 1 year ago

We currently determine whether or not to flag events based on whether or not they start with "On". This can lead to non-event functions being tagged as events, such as "OnlyDoIf". We need to implement proper analysis on whether or not a function is an event for both skyrim and fallout4.

Orvid commented 1 year ago

If a better analysis is needed, it would be worth extending that to FO4's custom events, as they are not currently recorded anywhere in the pex, so you just have to find what places manually invoke the custom event and make sure to emit that event.

nikitalita commented 1 year ago

If they're not recorded anywhere in the pex, how can we tell what's a custom event?