OsaSoft / youtube-better-subscriptions

This extension for Firefox and Chrome aims to make navigating YouTube's subscription grid easier by allowing users to hide watched videos
GNU General Public License v3.0
116 stars 19 forks source link

YT changed again? I am seeing all my watched vids #147

Closed gregkopp closed 10 months ago

gregkopp commented 10 months ago

I am seeing all my watched vids with the red bar, and there's no longer a "mark watched" eye-con.

GEHORC commented 10 months ago

Same here...

SSJ3Goku commented 10 months ago

Same.

OsaSoft commented 10 months ago

Oh great... Seems like youtube is rolling out yet another update i guess... Those affected, can you send a screenshot and the source of the page? I can try to figure out if theres a simple way for me to fix it without actually having the new version myself 😅

On Tue, 29 Aug 2023, 22:37 SSJ3Goku, @.***> wrote:

Same.

— Reply to this email directly, view it on GitHub https://github.com/OsaSoft/youtube-better-subscriptions/issues/147#issuecomment-1698094671, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACD3XZ5IZH5D6M2OTZ47QTDXXZHKBANCNFSM6AAAAAA4DMMIXQ . You are receiving this because you are subscribed to this thread.Message ID: @.*** com>

Urhas commented 10 months ago

Same issue here. Source attached subscriptions.txt

Errors : [YT-Better-Subs] ERROR! Cannot read properties of undefined (reading 'remove')

TypeError: Cannot read properties of undefined (reading 'remove') at buildMarkWatchedButton (subs-ui.js:152:34) at SubscriptionVideo.addButton (SubscriptionsVideo.js:15:26) at removeWatchedAndAddButton (subs-ui.js:242:17) at subs.js:118:21

*edited to add source

gregkopp commented 10 months ago

YouTube.zip

Screen shot and source code attached

SSJ3Goku commented 10 months ago

Here is a screenshot of my feed and the source code.

Bolongna commented 10 months ago

Same here, Both on Edge and Chrome. There is a hide item in the 3 dot menu and it did hide one video after I watched it but it acts like it ignores better subs after that.

gregkopp commented 10 months ago

Seems like if the first videos in my subscription feed have been watched, they are hidden. But once it gets to an unwatched video, every video after that, watched or unwatched, is shown in my feed. Although even that seems a bit intermittent.

niai commented 10 months ago

Been using this pull request for a few hours now and not seeing any issues. Thanks @ericfrazer

gregkopp commented 10 months ago

Trying it myself. Looks good so far.

SSJ3Goku commented 10 months ago

Ok so how do I fix this myself? I dunno what a pull request is, haven't done anything with code before.

OsaSoft commented 10 months ago

Thanks @ericfrazer ! Rolling out the update asap

OsaSoft commented 10 months ago

Firefox has been approved. You can either wait for the browser to automatically update, or you can get the new version quicker by typing about:addons into the url address, then the little settings wheel on the top right and "Check for Updates".

Chrome has still not been approved

OsaSoft commented 10 months ago

Actually, chrome has just been approved as well :)

SSJ3Goku commented 10 months ago

Hooray chrome is fixed!

isgdre commented 10 months ago

Thanks for the quick turn around.
It's shocking to me how bad YouTube's standard interface is.

Bolongna commented 10 months ago

Thanks for the quick patch. I did notice that if I hide a video using yts own hide that on refresh there are no blank spaces. Is there any way that could be used in YT better subs? Like maybe the watched button could also hit the hide toggle? Don't do any modern coding so not sure if that's a possible thing. That might cure the empty spaces.