search

OsaSoft / youtube-better-subscriptions

This extension for Firefox and Chrome aims to make navigating YouTube's subscription grid easier by allowing users to hide watched videos
GNU General Public License v3.0
122 stars 21 forks source link

The older videos never load if all newer videos are viewed #45

Closed ddrzn closed 6 years ago

ddrzn commented 6 years ago

When the checkbox "hide all videos" is checked and all newer videos are viewed (so there is no scrollbar), the older videos never loads. Adding manually a scrollbar (for example with a simple css min-height: 101vh;) seems to fix the problem.

OsaSoft commented 6 years ago

Hey, hmm thats weird. There is functionality in place that launches the "load more" procedure on YT when all videos are hidden in the new Polymer layout, and Ive tested Mark all as watched in old layout to see that it loads automatically.

Could you please provide some more info on your setup? (screenshots, if there are any errors in console log, etc)

Thanks

ddrzn commented 6 years ago

Well, my bad, I had this error but now I can't reproduce it anymore. Sorry for the waste of time !

OsaSoft commented 6 years ago

No worries, glad its no longer an issue for you. If you find anything else, or have any cool ideas for improvements, let me know!

ddrzn commented 6 years ago

I have this problem again, there is no error in the console :

capture

The loading just stops, and without any scrollbar I cannot force the loading.

It's really strange, I've not any clue on why it appens...

OsaSoft commented 6 years ago

Ah, I think I know whats happening thanks to the screenshot. Seems like an edge case I didnt account for. Thanks for the info, Ill take a look at it hopefully soon

ddrzn commented 6 years ago

Perfect, if you need more informations just ask me !

ZeebaEata commented 6 years ago

I had this issue too and have investigated it (from the user side). Seems like the loading stops after all the videos that have been initially present on screen are hidden.

To force further loading of the videos, you can scroll the left sidebar. Sometimes mere hovering the mouse over the sidebar initiates further loading.

OsaSoft commented 6 years ago

Im almost sure its because the way the load more videos is triggeres atm is only performed when there are NO visible videos. So if there is one or two vids that arent hidden, it doesnt get triggered

OsaSoft commented 6 years ago

@ZeebaEata thanks for that info! I was able to use that to do a nice workaround to forcing YT to load more videos. The fix for this will be rolling out soon in version 0.8.1

ZeebaEata commented 6 years ago

OsaSoft, glad to be of help! Thank YOU for the most useful add-on!