Closed Dimfred closed 1 year ago
Merging #84 (302be55) into master (41fde54) will decrease coverage by
3.6%
. The diff coverage is80.0%
.:exclamation: Current head 302be55 differs from pull request most recent head 24a7263. Consider uploading reports for the commit 24a7263 to get more accurate results
@@ Coverage Diff @@
## master #84 +/- ##
========================================
- Coverage 93.4% 89.8% -3.6%
========================================
Files 5 5
Lines 243 276 +33
========================================
+ Hits 227 248 +21
- Misses 16 28 +12
Impacted Files | Coverage Δ | |
---|---|---|
lua/rsync/project.lua | 85.7% <45.4%> (-10.0%) |
:arrow_down: |
lua/rsync/init.lua | 94.3% <85.0%> (-3.9%) |
:arrow_down: |
lua/rsync/sync.lua | 88.3% <85.7%> (-1.9%) |
:arrow_down: |
lua/rsync/config.lua | 100.0% <100.0%> (ø) |
Hi, thanks for the PR. Next time try to separate the features into multiple smaller ones tho. Preferably one PR per issue, as that's easier to review.
Try to get the lints passing and update the tests and I will check this.
Yeah sry it was late and I was just doing all things at the same time sort of so this gut a bit messy 😅 I saw that you have tests if you are in general fine with the PR I'll write them too.
EDIT:
Sry didn't see that with the tests, I'll do that.
Can you give me the command how to run the tests, I'll add to the README, never ran tests in lua
EDIT2:
Saw contribute.md nvm make test
Hi, good work, but please separate this into multiple smaller PR:s.
Should close #83
82 maybe more hooks?
81
62
Partially #5
I think my log flag should not be used, probably the log level from plenary should be exposed, but it's late, I'll guess I'll fix that in the next days.