search

OscarGodson / EpicEditor

EpicEditor is an embeddable JavaScript Markdown editor with split fullscreen editing, live previewing, automatic draft saving, offline support, and more. For developers, it offers a robust API, can be easily themed, and allows you to swap out the bundled Markdown parser with anything you throw at it.
http://epiceditor.com
MIT License
4.25k stars 334 forks source link

AMD compatible #327

Closed koorgoo closed 10 years ago

koorgoo commented 10 years ago

I use Require.js to load modules. A little change is required to make EpicEditor compatible with AMD.

OscarGodson commented 10 years ago

Seems good to me. Couple things:

  1. Are you comfortable writing a small test for this? Just make it so define is a function and define.amd is truthy and make sure define is called and returns EpicEditor?
  2. Can you build the files? Just jake build https://github.com/OscarGodson/EpicEditor/wiki/Contributing

If not I'm not totally sure when I can get to it, but I can try later this week maybe.

koorgoo commented 10 years ago

Nice. Will do after work. Thanks!