OscarGodson / EpicEditor

EpicEditor is an embeddable JavaScript Markdown editor with split fullscreen editing, live previewing, automatic draft saving, offline support, and more. For developers, it offers a robust API, can be easily themed, and allows you to swap out the bundled Markdown parser with anything you throw at it.
http://epiceditor.com
MIT License
4.25k stars 338 forks source link

Make CSS csslint compliant #398

Closed v1p closed 8 years ago

v1p commented 8 years ago

I love the EpicEditor, but the provided css i not usable as my project have strict csslint in works. It'll be great to make the css more compliant to available linters, so as there's less friction in using it.

Thanks!

OscarGodson commented 8 years ago

Might be hard. Everyone has different rules for their CSS.

Just one example, the following CSS I've seen written in these forms in different projects:

.this { color: #000; }
.this2 { color: #f00; }
.this { 
  color: #000; }
.this2 {
  color: #f00; }
.this { 
  color: #000;
}
.this2 {
  color: #f00;
}

Would all of those be compliant with csslint?

v1p commented 8 years ago

All the styles above are valid. I am talking about the most used csslint.net. Primarily, csslint raises errors for using # in defining styles. But yes you are correct that everyone has different rules for their CSS.

I was thinking more in the direction that a pluggable library, either have to share a guide/list of exceptions i.e. how to make it work with such linter tools, or make itself available in the most acceptable format across the ecosystem.

v1p commented 8 years ago

For now, adding an exception rule to the app's CSS the following way works:

/* csslint ignore:start */
@import('epiceditor.css');
/* csslint ignore:end */

I'll close this comment. It was merely a suggestion to have CSS done in a compliant way.