search

OscarGodson / jKey

Key shortcuts made simple
http://oscargodson.github.com/jKey/
185 stars 40 forks source link

jKey unbind method #14

Closed vala closed 11 years ago

vala commented 13 years ago

Hi there, I got a first version of the unbind method implementation. I added a 6th example in samples.html that I'd like you to review so it integrates well with your other ones. So I didn't updated the README file. I hope you won't be scared of the changes cause there has been a big part of rewriting the way the plugin handles key events bindings. The unbind method was the smallest part. I'm not convinced it's the better way, nor it's very well optimized, I focused on making it work, so I'm completely open to suggestions about modifications of the way it works or the way if it isn't written the way you did it at first. Thanks for your review and hope you'll like the patch.

vala commented 12 years ago

Any update about that ?

OscarGodson commented 12 years ago

Oh man, never saw this! Don't think I was ever notified. I always respond to pull requests and this is one major one. Checking it out now.

OscarGodson commented 12 years ago

So, there's some issues with this.

  1. Minor thing, there's still console logs in the source ;)
  2. The key presses aren't logging the right stuff. They all say "woot". I.e. the left and right keys should trigger a console log saying "left" or "right", but I just see "woot !"