Why is the new attribute called shortIconRef and not shortIcon ?
Could you create 2 PRs please? One for the youtube shorturl pattern, the other for the shortIcon
Would you mind adding at least a test for that in test/parser.js or modify all current tests so all tests pass ? (I had to modify the tests today because 2 of the test websites changed, so you will need to rebase your changes)
I also added our eslint config on the newest version of master, please use this one to format the code 😅
Hi there !
Thanks for the contribution. 🙂
A few questions/requirements :
shortIconRef
and notshortIcon
?youtube shorturl pattern
, the other for theshortIcon
test/parser.js
or modify all current tests so all tests pass ? (I had to modify the tests today because 2 of the test websites changed, so you will need to rebase your changes)eslint
config on the newest version ofmaster
, please use this one to format the code 😅Thanks a lot in advance !