search

Oshan96 / monkey-dl

Bulk download your favourite anime episodes from your favourite anime websites
MIT License
819 stars 71 forks source link

Defender clocked the exe as being malacious. #25

Open Sharkaboi opened 4 years ago

Sharkaboi commented 4 years ago

Was downloading Jojo from gogoanime since about 10 hrs, Settings if it helps : 720p, ep 1-23 , stardust egypt arc. Running 4 Threads, encountered two non HLS links and started two ffmpeg instances and I think it crashed/was terminated after one ffmpeg download finished (only one file was completed).

image

Oshan96 commented 4 years ago

Can you tell me the version you're using?

And about the antivirus software flagging this as a trojan is a false positive. I have addressed this separately in multiple issues but I should address this in README as well.

This happens because of the subprocess statements (to run FFMPEG) in the code (you can see them in source code) mostly. Apart from that, the other reason is because of the the use of Cypto libraries to decrypt encrypted URLs from websites like Twist.

The subprocess call will be removed in a later version release with the removal of FFMPEG dependency (currently working on it and is optional in monkey-dl version, but didn't remove it completely soon) and hopefully the false positive torjan alert will be solved

Sharkaboi commented 4 years ago

Running latest v1.04 . Ye figured it was a ffmpeg issue, I knew it wasn't actually a Trojan but saw the whole process was killed and the exe was missing and found it to be quarantined .

Also just a suggestion, but there's an api for whole collection from horriblesubs if you want that as an option.

Oshan96 commented 4 years ago

Can you provide me the link to the API? So that I'll look into it. As long as it provides direct links, I will be able to plug it in monkey-dl.

PS: Once I came along an API for HorribleSubs, but the provided download links (direct) were hard to retrieve since it had all sorts of limited downloads per hour and such. Not sure you're referring to the same :D

Sharkaboi commented 4 years ago

This one used web torrent i think, needs node js. https://pypi.org/project/horrible-downloader/ Their direct download servers are premium i think, and they all have bandwidth limits. They also have this option in their website, but i guess it's not that easily of a system to integrate. https://horriblesubs.info/irc-guide/

Oshan96 commented 4 years ago

Yup. This is the API I came across, and I've checked the wrapper also. The thing is monkey-dl does not have a torrent client integrated within; and I do not want to have external dependencies on this as as well (that's why I took care of FFMPEG dependency as well). I have checked for pure python based torrent client API's and found some promising ones as well. If either one of them works as to my expectations, I might integrate a torrent client as well so I will be using the horriblesub magnet links from their API to download the files.

As for now I'm only looking for the direct links and yeah, as stated, horriblesubs direct downloads are in premium servers and it's an issue as of now. If someone finds a way for this and does a PR with the fixes for that I will be glad to merge it :)