search

Oshan96 / monkey-dl

Bulk download your favourite anime episodes from your favourite anime websites
MIT License
814 stars 70 forks source link

Searching functionality... #50

Open ArjixWasTaken opened 3 years ago

ArjixWasTaken commented 3 years ago

Welp, just like in anime-dl/anime-downloader, I want to get your opinion on searching functionalities...

As a feature it would need a lot of rework in the core of the repo. But I believe it's worth the effort.

Once I get familiar with the inner workings of monkey-dl, I'll try to add it myself, but adding a feature whilst not knowing if it will actually get merged does not sound nice. (Yes, I know that you have to look at my PR to decide if you want it to be merged or not, I'm just asking if you would like this in general.)

Oshan96 commented 3 years ago

Hi @ArjixGamer, I do like the idea of the searching functionality, and I'll gladly accept any pull request with such functionality. However, since I have completely reworked the packages and some of the files in dev branch, it would be best to be working and sending a PR to the dev branch (otherwise we both will have issues, just like the other PR on hold because it gives me collisions and I don't have too much time to completely go through and fix old packages and files too)

Any help is appreciated, and as I have mentioned, the main reason for the PR was not merged yet was because of the issues I have mentioned above.