search

Oshan96 / monkey-dl

Bulk download your favourite anime episodes from your favourite anime websites
MIT License
816 stars 71 forks source link

Provider related stuff #51

Open ArjixWasTaken opened 3 years ago

ArjixWasTaken commented 3 years ago

So, we have no way to contact each other, that's why I am making an issue where we can discuss on provider related stuff.

First of all, Since you are using cloudscraper, and the requests library is a dependency for cloudscraper, That means that I can directly Import the requests library, right? Using a session for simple api calls (the provider im working on) sounds like a pain.

Also, I suggest writing wrapper functions in the util file, that way we can use smth like util.soup(html) for parsing html or util.get(link) and util.post(link, data) for requests that dont need a session. PS: If you have no problem with the helper functions then I can just add them along with my PR

ArjixWasTaken commented 3 years ago

aight, i managed to write a provider for shiro.is

ArjixWasTaken commented 3 years ago

can you, idk, change the bot that checks the quality of the code? i follow pep standards and it always has a problem against me...

Oshan96 commented 3 years ago

I'll look into it, I rarely have issues with it since I have configured my environment (I guess, if I remember right)