search

OsiriX-Foundation / kheops

20 stars 11 forks source link

Add env variable to disable matching tags verification #56

Closed roger-schaer closed 1 year ago

roger-schaer commented 1 year ago

The environment variable KHEOPS_AUTHORIZATION_DISABLE_VERIFICATION can be used to disable the verification of matching tags for studies & series during the "VerifyInstance" action, delegating the ability to merge/overwrite fields such as PatientID to the underlying DCM4CHEE instance.

The environment variable can be omitted completely or set to any value other than "true" to keep the default behavior of Kheops.

This can be useful in research settings, when data may be updated several times over the course of the project.

Feel free to adapt the name of the environment variable or variables within the code if they do not match your current coding guidelines.

nikpap commented 1 year ago

Hello @roger-schaer, do you think you could adapt the code to fit our existing environment variables?

eg https://github.com/OsiriX-Foundation/kheops/blob/main/Authorization/setenv.sh#L113 https://github.com/OsiriX-Foundation/kheops/blob/main/Authorization/context.xml#L26 https://github.com/OsiriX-Foundation/kheops/blob/main/Authorization/src/main/java/online/kheops/auth_server/resource/UserResource.java#L248

Thanks!

roger-schaer commented 1 year ago

Hi @nikpap, of course, I adapted the code now and hope it better corresponds to the existing environment variables mechanism now.

nikpap commented 1 year ago

Hello @roger-schaer, I apologize for taking so long to get back to you, but the last few weeks have been quite packed.

Thanks for updating your code.

I'll look into it in detail as soon as I have some free time, but it will probably take a few more days.

roger-schaer commented 1 year ago

Hi @nikpap, could you check the status of this PR? Thanks in advance!

nikpap commented 1 year ago

Hello @roger-schaer, I apologize for not looking into this earlier, I'll check everything by the end of the week.

nikpap commented 1 year ago

Thank you for your PR; I apologize for not having any time to check into this earlier.

KHEOPS_AUTHORIZATION_DISABLE_VERIFICATION has now been merged and is available on v1.1.1 of Kheops. Let me know if you encounter any issue @roger-schaer .