search

OskarStark / SonataAdminBehatContext

a Behat context for SonataAdmin
MIT License
6 stars 1 forks source link

UserBundle made optional #42

Closed goetas closed 2 years ago

goetas commented 3 years ago

Hi @OskarStark ! Would you be interested in this change?

The user bundle brings a lot of complexity and we do not need it, but the rest of the package is great!

If you are interested, tests can be provided.

cc @kamilmusial

OskarStark commented 3 years ago

Would you be interested in this change?

Hi, yes this looks good to me, another option would be to create a dedicated context?

OskarStark commented 3 years ago

Can you please rebase?

kamilmusial commented 3 years ago

Would you be interested in this change?

Hi, yes this looks good to me, another option would be to create a dedicated context?

Hi, thanks for the comments. Another context seems good to me as well, it's up to you.

OskarStark commented 3 years ago

Let's keep it in one context the deprecations are not worth the result IMO. 👍🏻

OskarStark commented 3 years ago

Please add some tests

goetas commented 2 years ago

replaced by https://github.com/OskarStark/SonataAdminBehatContext/pull/44