Split the context in two to not depend on the sonata user bundle

OskarStark / SonataAdminBehatContext

a Behat context for SonataAdmin

MIT License

6 stars 1 forks source link

Split the context in two to not depend on the sonata user bundle #44

Closed goetas closed 2 years ago

goetas commented 2 years ago

hi @OskarStark , it you are interested in this type of change, i can fix the conflicts and add some tests.

OskarStark commented 2 years ago

Please go ahead 👍🏻🙏💡

goetas commented 2 years ago

@OskarStark all the changes have been done. I did not do any logic-change to the code, i've just moved it into a separate class. The features that were depending on the user bundle had zero test coverage. Now i've added a test for each behat step.

I think that this is a breaking change and it will require a 2.0 release of this package.

OskarStark commented 2 years ago

I pushed a 1.x branch based on master.

Can you please add some CHANGELOG?

Plus, are you willing to join the repo as a contributor? I am not using this lib anymore...

goetas commented 2 years ago

I pushed a 1.x branch based on master.

:+1:

Can you please add some CHANGELOG?

Done

Plus, are you willing to join the repo as a contributor? I am not using this lib anymore...

Sure. We are using it in a project (and I had also one or two feature to add :) )

(i will have to figure out how to fix the cs failures (