Oslandia / SFCGAL

MOVED TO GITLAB: https://gitlab.com/sfcgal/SFCGAL. A wrapper around CGAL that intents to implement 2D and 3D operations on OGC standards models
https://sfcgal.org
Other
112 stars 54 forks source link

Issue 200 fix intersection #201

Closed danielcumberbatch closed 4 years ago

danielcumberbatch commented 5 years ago

Fix for issue #200.

mhugo commented 5 years ago

@danielcumberbatch Thanks for your proposition.

I am lacking time to review your PR in depth.

But at first sight, I see you are using Nef_polyhedron, which we decided to avoid, because it is very slow. We rely on corefinement for boolean operations. See here for instance.

danielcu888 commented 4 years ago

@mhugo thanks for your comment. I will review the reference that you have sent and update my submission. Thanks.