Oslandia / SFCGAL

MOVED TO GITLAB: https://gitlab.com/sfcgal/SFCGAL. A wrapper around CGAL that intents to implement 2D and 3D operations on OGC standards models

https://sfcgal.org

Other

112 stars 54 forks source link

Closed metux closed 4 years ago

metux commented 4 years ago

CGAL::intersection returns bool, so just simple 'if' instead of comparing with 'boost::none', which isn't comparable to 'bool'.

Signed-off-by: Enrico Weigelt, metux IT consult info@metux.net

sloriot commented 4 years ago

intersection returns an optional of a variant not a bool. On some compiler the conversion of optional to variant was triggering a warning.

mhugo commented 4 years ago

I have no strong opinion and tend to follow @sloriot 's comment. So it is safer not to touch it ...

metux commented 4 years ago

intersection returns an optional of a variant not a bool. On some compiler the conversion of optional to variant was triggering a warning.

in my case it triggered an build error: couldn't find an matching != operator.

mhugo commented 4 years ago

209 has been merged instead