search

Oslandia / SFCGAL

MOVED TO GITLAB: https://gitlab.com/sfcgal/SFCGAL. A wrapper around CGAL that intents to implement 2D and 3D operations on OGC standards models
https://sfcgal.org
Other
112 stars 54 forks source link

Issue #130: Add 3D linear referencing #226

Closed danielcu888 closed 4 years ago

danielcu888 commented 4 years ago

Implemented functionality requested by Issue #130 to retrieve a segment of a specified (2D or 3D) LineString, between the specified fractional distances from the start of the specified LineString.

lbartoletti commented 4 years ago

Thanks Daniel. We'll review your PR very soon. Can you delete the DS-store files and add this entry to the gitignore please?

danielcu888 commented 4 years ago

@lbartoletti absolutely, apologies for that.

danielcu888 commented 4 years ago

@lbartoletti thanks for the approval. Can it now be merged?

lbartoletti commented 4 years ago

Thanks @danielcu888! Works much appreciated.

Only one question, what do you think about rename LineSegment to LineSubstring?

danielcu888 commented 4 years ago

@lbartoletti yes, LineSubstring does sound better, I'll make the change.

danielcu888 commented 4 years ago

@lbartoletti I have now made the change requested.

lbartoletti commented 4 years ago

Thank you!