peppsac
commented
5 years ago Regarding the first question: AFAIU, requirements.txt should contain the output of pip freeze = all the resolved dependencies with their specific version. On the other hand, setup.py contains unversionned dependencies.
So there are 2 ways of installing py3dtiles:
pip install [-e] PY3DTILES_FOLDERpip install -r PY3DTILES_FOLDER/requirements.txt
Regarding the 2nd question: yes, virtualenv -p python3 venv would be better
delhomer
Is requirements.txt still used ?
The from sources installation commands currently require to launch a
pip install -e .. I don't know why (since I don't much about python install/distutils/setup thingies) but I can succeed with my py3dtiles installation without running that command.Actually I can remove the
requirements.txtfile at all and the installation still succeeds.Hence my question: are they some use cases or contexts where
requirements.txtand thepip install -e .are required for things to run smoothly ?I'm asking this because when you add a new module requirement to py3dtiles, you currently apparently seem to need to update both
requirements.txtand the requirements section of setup.py (which doesn't look that DRY?).Do we need to hard wire the path to python3 in command
virtualenv -p /usr/bin/python3 venv?The installation commands also mention to
virtualenv -p /usr/bin/python3 venv. Yet on OSX the python3 interpreter is not located by default in/usr/bin(both native and homebrew versions). I thus had to runvirtualenv -p python3 venvwhich looks more platform independent (it suffice to change your PATH to point to a specific version prior to launching the command).