search

Oslandia / py3dtiles

:warning: Project migrated to : https://gitlab.com/py3dtiles/py3dtiles :warning:
https://py3dtiles.org
Other
215 stars 76 forks source link

Fix issue 30 #40

Closed peppsac closed 6 years ago

peppsac commented 6 years ago

2 commits to adapt the code to 3dtiles 1.0 specification.

Fixes #30

Jeremy-Gaillard commented 6 years ago

Since we're removing the glTFUpAxis property, can you add in the export_tileset documentation that we expect mesh geometries to be Y-up? Or change the parse so that it can flip the coordinates, or even change the SQL query so it does the Y to Z transform.

peppsac commented 6 years ago

Since we're removing the glTFUpAxis propert

To make myself clear: I'm removing it because it's not supported anymore in the spec (cf https://github.com/AnalyticalGraphicsInc/3d-tiles/tree/master/specification#gltf).

can you add in the export_tileset documentation that we expect mesh geometries to be Y-up?

Yes good idea.

Or change the parse so that it can flip the coordinates, or even change the SQL query so it does the Y to Z transform.

I believe you meant to write Z->Y transform?

Jeremy-Gaillard commented 6 years ago

To make myself clear: I'm removing it because it's not supported anymore in the spec (cf https://github.com/AnalyticalGraphicsInc/3d-tiles/tree/master/specification#gltf).

Yes, I fully agree with the intent of this PR. We should also check one of these days if any other aspect of the spec changed when AGI pushed the definitive 1.0 spec in august.

I believe you meant to write Z->Y transform?

Indeed, my bad.

peppsac commented 6 years ago

@Jeremy-Gaillard do you think you can fix the sql query to perform the transformation? I'm not at ease with this part of the code yet :)

Jeremy-Gaillard commented 6 years ago

I'll take a look at it tomorrow or at the begining of next week.

Jeremy-Gaillard commented 6 years ago

Done!

peppsac commented 6 years ago

Thanks @Jeremy-Gaillard!