Closed EricBoix closed 4 years ago
Thanks for your work on this PR.
A few remarks before I take a closer look to the PR:
header
attribute (i.e. replace self.header["attribute"]
by self.attribute
, or just change the name if you want to keep all attributes in a dictionary)BoundingVolume.set
by BoundingVolume.setBox
, BoundingVolume.setRegion
, BoundingVolume.setSphere
so you don't need to test the validity of the volume afterwards
This PR should not be merged and is only a base for commenting/discussing some WIP as proposition for issue #27 .