search

OsmSharp / ui

The UI components.
http://osmsharp.com/
GNU General Public License v2.0
138 stars 91 forks source link

Route instructions are sometimes incomplete #229

Closed JoeCooper closed 8 years ago

JoeCooper commented 9 years ago

I'm including an image. For the route shown on the left – which resolves and renders correctly – I get near-empty instructions. (Only the starting and ending POI are in the instruction series.)

If you still have my files, you can reproduce it with the following coordinates:

From: 47.1480665604869, -102.461533504644 To: 47.18302107, -102.49835487

route-interpretation

I dug in a bit and found the misbehavior seems to happen somewhere in MicroPlanner; the route seems to be perfectly valid and AggregatedPoint that goes in seems to be valid (so far as I can tell) but none of the "machines" seem to come up with anything except for PoiMachine and PoiWithTurnMachine.

The second instruction has the next "poi" and nothing else, which (as shown in the screenshot here) is processed a bit.

xivk commented 9 years ago

Thanks, this is definetly a bug. There should at least be one instruction that says something like 'Turn left onto {streetname}'.

Am I also correct in assuming that you are also missing instructions like 'Start heading west/north/east/south on {streetname}'. Something that is not common in Europe but is used in the US?

JoeCooper commented 9 years ago

It's completely empty except for the two "poi" instructions.

Many routes do appear correctly, with turns listed and all that, but this one (and many positions reasonably near to the target location) do not generate anything.

JoeCooper commented 9 years ago

Hey how's this coming?

JoeCooper commented 8 years ago

I can't reproduce this anymore. If I do find such a problem again and trace it to OsmSharp than I'll fix it and send a pull request.