search

OsmTravel / OsmGo

Osm Go !
https://osmgo.com/
MIT License
102 stars 14 forks source link

Strengthen typings #116

Open dotcs opened 2 years ago

dotcs commented 2 years ago

I found that typings are used rather weakly in this project. I could offer some support to improve the typings in this project. Adding type safety should make the code more robust. Also it should help to improve the developer experience - especially for newcomers. Is this something maintainers would like to see?

Binnette commented 2 years ago

Feel free to make some PR 👍

dotcs commented 2 years ago

I've added a couple more PRs to improve the typings in the project. I'm making good progress here. ☺️ @DoFabien and @Binnette please go through those PRs in order when reviewing them as they sit on top of each other and thus are (partially) dependent. We can merge them one-by-one. GitHub should then automatically rewrite the target to develop once a parent branch has been merged to develop.