Fix moving cursors when fuzzy matching is enabled

Osmose / advanced-open-file

Open files and folders in Atom easily.

https://atom.io/packages/advanced-open-file

Other

118 stars 20 forks source link

Fix moving cursors when fuzzy matching is enabled #106

Closed itiut closed 8 years ago

itiut commented 8 years ago

This fixes #105.

When fuzzy matching is enabled, the if statement in view.js#L152-L159 is not executed and matchingPaths in this scope is equal to ones in file-service's matchingPathCache. So matchingPaths.unshift in view.js#L169 updates the cache itself, which causes incorrect behaviour.

Osmose commented 8 years ago

This looks good to me. There's some other things we could do better around the cache, but this will work fine for now. Thanks for the patch!

Osmose commented 8 years ago

This has been released as v0.16.2.

itiut commented 8 years ago

Thanks!